This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[IAP] Clean up Dart unit tests #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename `PlatformViewsController` to `FakeInAppPurchasePlatform` to more accurately describe what it's faking. Remove the overcomplicated `Channel` class and just set a mock handler on the `const MethodChannel` used by the entire plugin itself.
amirh
reviewed
Jan 15, 2019
packages/in_app_purchase/lib/src/billing_client_wrappers/billing_client_wrapper.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/lib/src/store_kit_wrappers/sk_payment_queue_wrapper.dart
Outdated
Show resolved
Hide resolved
packages/in_app_purchase/test/fake_in_app_purchase_platform.dart
Outdated
Show resolved
Hide resolved
andreidiaconu
pushed a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
Rename `PlatformViewsController` to `StubInAppPurchasePlatform` to more accurately describe what it's stubbing. Remove the overcomplicated `Channel` class and just set a mock handler on the `const MethodChannel` used by the entire plugin itself.
andreidiaconu
added a commit
to andreidiaconu/plugins
that referenced
this pull request
Feb 17, 2019
This reverts commit 0361d01.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
PlatformViewsControllertoStubInAppPurchasePlatformto moreaccurately describe what it's stubbing. Remove the overcomplicated
Channelclass and just set a mock handler on theconst MethodChannelused by the entire plugin itself.