Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/plugins
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 04ea39a
Choose a base ref
...
head repository: flutter/plugins
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 90fd90e
Choose a head ref
  • 1 commit
  • 13 files changed
  • 1 contributor

Commits on Aug 17, 2021

  1. [url_launcher] Add native unit tests for Windows (#4156) 

    Adds a unit test target based on googletest. This is intended to be both a set of unit tests for this plugin, and also a model of changes that can be made to the `flutter create` template for Windows plugins to include better testing out of the box (flutter/flutter#82458).

In addition to the test binary being directly runnable, the integration between CMake, VS, and googletest means that these tests are visible—and runnable—in the VS Test Explorer UI after opening the generated .sln file.

Changes for testing in general:
- Moved the plugin class declaration to a header.
- Moved the C registration API implementation to a separate file.
- Added (opt-in, so it won't affect plugin client builds) plugin CMake rules to download googletest and build a new executable target that builds all the plugin sources, plus gtest and gmock.
- Added a line to the example app CMake rules to enable the unit tests.
- Added a unit test file.

url_launcher-specific changes:
- Wrapped all Win32 calls in a thin class for mockability in unit tests.
- Factored some logic into helpers for better maintainability while I was refactoring anyway.

Note: This unit test is not yet being run by CI. A tools command to run Windows plugin unit tests will be a separate PR.

Part of flutter/flutter#82445
    @stuartmorgan-g
    stuartmorgan-g authored Aug 17, 2021
    Configuration menu
    Copy the full SHA
    90fd90e View commit details
    Browse the repository at this point in the history
Loading