Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/plugins
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a4f0e88fca1e
Choose a base ref
...
head repository: flutter/plugins
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 70c314ce53cf
Choose a head ref
  • 1 commit
  • 17 files changed
  • 1 contributor

Commits on Sep 11, 2021

  1. [google_maps_flutter_web] Fix getScreenCoordinate, zIndex of Circles (#…

    …4298)
    
    This commit:
    
    * uses the zIndex attribute when converting Circle geometry objects.
    * ensures that the getScreenCoordinate method works as expected on the web platform.
      * adds tests that can use a fully-rendered Google Map (see projection_test.dart)
        * changes the initialization flow of the web Google Map, so the Controller is only returned to the main plugin when it's ready to work.
    
    In order to test the getScreenCoordinate method, the Controller of a fully-rendered map must be available on the test, so we can retrieve information from an actual map instance. While working on this, it was observed that the Controller was being sent to the programmer before it was truly ready (while the map was still initializing).
    
    Instead of littering the test with imprecise timeouts that may make these tests slower (and flakier) than needed, this PR also changes the initialization process of a GMap slightly so when its Controller is returned to the user of the plugin (onPlatformViewCreated method call), it is truly ready.
    
    For this: 
    
    * Controller.init is immediately called after the controller is created, 
    * The plugin waits for the first onTilesloaded event coming from the JS SDK, and then 
    * The Controller is sent to the user
    
    This change happens within "private" sections of the plugin, so programmers using the plugin "normally" shouldn't notice any difference whatsoever (only that the GMap might load slightly faster, and the onPlatformViewCreated callback might be firing a few hundred milliseconds later).
    ditman authored Sep 11, 2021
    Configuration menu
    Copy the full SHA
    70c314c View commit details
    Browse the repository at this point in the history
Loading