Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 6bc9a2b

Browse files
mvanbeusekommvanbeusekom
authored
[webview_flutter] Clean up prefer_const_constructor ignore statements (#4553)
1 parent f581e13 commit 6bc9a2b

File tree

4 files changed

+17
-37
lines changed

4 files changed

+17
-37
lines changed

‎packages/webview_flutter/webview_flutter_android/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## NEXT
2+
3+
* Updates to webview_flutter_platform_interface version 1.5.2.
4+
15
## 2.3.1
26

37
* Adds explanation on how to generate the pigeon communication layer and mockito mock objects.

‎packages/webview_flutter/webview_flutter_android/example/lib/web_view.dart‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -568,9 +568,7 @@ class WebViewController {
568568
bool? hasNavigationDelegate;
569569
bool? hasProgressTracking;
570570
bool? debuggingEnabled;
571-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
572-
// ignore: prefer_const_constructors
573-
WebSetting<String?> userAgent = WebSetting<String?>.absent();
571+
WebSetting<String?> userAgent = const WebSetting<String?>.absent();
574572
bool? zoomEnabled;
575573
if (currentValue.javascriptMode != newValue.javascriptMode) {
576574
javascriptMode = newValue.javascriptMode;

‎packages/webview_flutter/webview_flutter_android/pubspec.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ flutter:
1919
dependencies:
2020
flutter:
2121
sdk: flutter
22-
webview_flutter_platform_interface: ^1.2.0
22+
webview_flutter_platform_interface: ^1.5.2
2323

2424
dev_dependencies:
2525
build_runner: ^2.1.4

‎packages/webview_flutter/webview_flutter_android/test/webview_android_widget_test.dart‎

Lines changed: 11 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,7 @@ void main() {
7070
creationParams: creationParams ??
7171
CreationParams(
7272
webSettings: WebSettings(
73-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
74-
// ignore: prefer_const_constructors
75-
userAgent: WebSetting<String?>.absent(),
73+
userAgent: const WebSetting<String?>.absent(),
7674
hasNavigationDelegate: hasNavigationDelegate,
7775
hasProgressTracking: hasProgressTracking,
7876
)),
@@ -123,9 +121,7 @@ void main() {
123121
creationParams: CreationParams(
124122
initialUrl: 'https://www.google.com',
125123
webSettings: WebSettings(
126-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
127-
// ignore: prefer_const_constructors
128-
userAgent: WebSetting<String?>.absent(),
124+
userAgent: const WebSetting<String?>.absent(),
129125
hasNavigationDelegate: false,
130126
),
131127
),
@@ -142,9 +138,7 @@ void main() {
142138
creationParams: CreationParams(
143139
userAgent: 'MyUserAgent',
144140
webSettings: WebSettings(
145-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
146-
// ignore: prefer_const_constructors
147-
userAgent: WebSetting<String?>.absent(),
141+
userAgent: const WebSetting<String?>.absent(),
148142
hasNavigationDelegate: false,
149143
),
150144
),
@@ -160,9 +154,7 @@ void main() {
160154
autoMediaPlaybackPolicy:
161155
AutoMediaPlaybackPolicy.require_user_action_for_all_media_types,
162156
webSettings: WebSettings(
163-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
164-
// ignore: prefer_const_constructors
165-
userAgent: WebSetting<String?>.absent(),
157+
userAgent: const WebSetting<String?>.absent(),
166158
hasNavigationDelegate: false,
167159
),
168160
),
@@ -177,9 +169,7 @@ void main() {
177169
creationParams: CreationParams(
178170
autoMediaPlaybackPolicy: AutoMediaPlaybackPolicy.always_allow,
179171
webSettings: WebSettings(
180-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
181-
// ignore: prefer_const_constructors
182-
userAgent: WebSetting<String?>.absent(),
172+
userAgent: const WebSetting<String?>.absent(),
183173
hasNavigationDelegate: false,
184174
),
185175
),
@@ -194,9 +184,7 @@ void main() {
194184
creationParams: CreationParams(
195185
javascriptChannelNames: <String>{'a', 'b'},
196186
webSettings: WebSettings(
197-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
198-
// ignore: prefer_const_constructors
199-
userAgent: WebSetting<String?>.absent(),
187+
userAgent: const WebSetting<String?>.absent(),
200188
hasNavigationDelegate: false,
201189
),
202190
),
@@ -214,9 +202,7 @@ void main() {
214202
tester,
215203
creationParams: CreationParams(
216204
webSettings: WebSettings(
217-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
218-
// ignore: prefer_const_constructors
219-
userAgent: WebSetting<String?>.absent(),
205+
userAgent: const WebSetting<String?>.absent(),
220206
javascriptMode: JavascriptMode.unrestricted,
221207
hasNavigationDelegate: false,
222208
),
@@ -231,9 +217,7 @@ void main() {
231217
tester,
232218
creationParams: CreationParams(
233219
webSettings: WebSettings(
234-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
235-
// ignore: prefer_const_constructors
236-
userAgent: WebSetting<String?>.absent(),
220+
userAgent: const WebSetting<String?>.absent(),
237221
hasNavigationDelegate: true,
238222
),
239223
),
@@ -248,9 +232,7 @@ void main() {
248232
tester,
249233
creationParams: CreationParams(
250234
webSettings: WebSettings(
251-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
252-
// ignore: prefer_const_constructors
253-
userAgent: WebSetting<String?>.absent(),
235+
userAgent: const WebSetting<String?>.absent(),
254236
debuggingEnabled: true,
255237
hasNavigationDelegate: false,
256238
),
@@ -265,9 +247,7 @@ void main() {
265247
tester,
266248
creationParams: CreationParams(
267249
webSettings: WebSettings(
268-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
269-
// ignore: prefer_const_constructors
270-
userAgent: WebSetting<String?>.of('myUserAgent'),
250+
userAgent: const WebSetting<String?>.of('myUserAgent'),
271251
hasNavigationDelegate: false,
272252
),
273253
),
@@ -281,9 +261,7 @@ void main() {
281261
tester,
282262
creationParams: CreationParams(
283263
webSettings: WebSettings(
284-
// TODO(mvanbeusekom): Cleanup and convert to const constructor when platform_interface is fixed (see https://github.com/flutter/flutter/issues/94311)
285-
// ignore: prefer_const_constructors
286-
userAgent: WebSetting<String?>.absent(),
264+
userAgent: const WebSetting<String?>.absent(),
287265
zoomEnabled: false,
288266
hasNavigationDelegate: false,
289267
),

0 commit comments

Comments
 (0)