Skip to content

Conversation

@ivirtex
Copy link
Contributor

@ivirtex ivirtex commented Feb 25, 2023

This PR adds a tool to compare page transitions between Flutter and native iOS.
Best effects are achieved when testing on a real device with a ProMotion display (simulators and non ProMotion devices also work but expect loss of precision on the graph due to twice as long frame times).

Features:

  • Resizable transition graph created in real time
  • Changeable resolution of the graph
  • Option to globally slow down the animations by 5 times
  • One button to trigger transition on both platforms

Things to consider:

  • Trigger transitions at the same vsync signal
  • Pass touch events to allow for analyzing animations of pages dropped mid-swipe
  • Find out if there is a better way to measure transition progress in Flutter

Fixes flutter/flutter#22862

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is awesome! Thank you for very much for putting this together.

@MitchellGoodwin MitchellGoodwin merged commit ce04b84 into flutter:master Feb 27, 2023
@MitchellGoodwin
Copy link
Contributor

@ivirtex there was some scorecard failures on the merge that you may have been notified about, but I think those can be ignored. Improving the routes in Cupertino is a big goal of mine, so I'm very excited to have this. Realistically, it will be about a month before I can work directly on the routes, but if you were planning on improving this tool or other work in this area, please don't hesitate to tag me or reach out on discord for discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a comparison tool for page transition

2 participants