[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

danferreira · 2025-09-06T00:59:15Z

Adds a new parameter canCreateDirectories to FileDialogOptions to control the visibility of the New Folder button in file dialogs on supported platforms.

Currently only configurable on Linux and macOS

This is the "Combined PR"
Let me know if we are okay with this approach so I can open a new PR covering the interface changes

Fixes: flutter/flutter#141339

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

stuartmorgan-g

Thanks for the contribution!

stuartmorgan-g · 2025-09-10T13:30:20Z

packages/file_selector/file_selector/lib/file_selector.dart

 ///
+/// [canCreateDirectories] controls whether the user is allowed to create new
+/// directories in the dialog (if supported on the platform).
+/// Currently only supported on Linux and macOS.


The app-facing package has no control over this, so it's subject to becoming stale (and misleading about unendorsed implementations). It should just say that it may not be supported on all platforms.

Agree. I changed the doc so that it infers less about the implementations
Let me know what you think

stuartmorgan-g · 2025-09-10T13:30:38Z

packages/file_selector/file_selector/CHANGELOG.md

-## NEXT
+## 1.1.0

+* Adds `canCreateDirectories` parameter to `FileDialogOptions` to control the visibility of the New Folder button in file dialogs on supported platforms.


FileDialogOptions shouldn't be mentioned at this level, since it's not the public API here.

Makes total sense.

Fixed manually all changelogs

packages/file_selector/file_selector/lib/file_selector.dart

stuartmorgan-g · 2025-09-10T13:32:16Z

packages/file_selector/file_selector/test/file_selector_test.dart

  const String initialDirectory = '/home/flutteruser';
  const String confirmButtonText = 'Use this profile picture';
  const String suggestedName = 'suggested_name';
+  const bool canCreateDirectories = true;


There's no need for this to be stateful in the tests; values should be local.

stuartmorgan-g · 2025-09-10T13:33:39Z

...or/file_selector_platform_interface/lib/src/method_channel/method_channel_file_selector.dart

This file shouldn't be changed; it's for legacy compat, and legacy implementations won't support new features.

...tor/file_selector_platform_interface/lib/src/platform_interface/file_selector_interface.dart

packages/file_selector/file_selector_linux/lib/file_selector_linux.dart

packages/file_selector/file_selector_linux/linux/test/file_selector_plugin_test.cc

packages/file_selector/file_selector_macos/lib/file_selector_macos.dart

...elector_macos/macos/file_selector_macos/Sources/file_selector_macos/FileSelectorPlugin.swift

stuartmorgan-g

Sorry for the delay in getting back to this. A few more comments on the cross-platform parts.

stuartmorgan-g · 2025-10-10T15:21:43Z

packages/file_selector/file_selector/test/file_selector_test.dart

      expect(location?.path, expectedSavePath);
    });
+
+    test('sets to disable the creation of new directories', () async {


'sets the directory creation control flag'

stuartmorgan-g · 2025-10-10T15:21:55Z

packages/file_selector/file_selector/test/file_selector_test.dart

      expect(directoryPath, expectedDirectoryPath);
    });
+
+    test('sets to enable de creation of new directories', () async {


stuartmorgan-g · 2025-10-10T15:22:02Z

packages/file_selector/file_selector/test/file_selector_test.dart

      );
      expect(directoryPaths, expectedDirectoryPaths);
    });
+    test('sets to enable de creation of new directories', () async {


stuartmorgan-g · 2025-10-10T15:23:58Z

packages/file_selector/file_selector/CHANGELOG.md

-## NEXT
+## 1.1.0

+* Adds `canCreateDirectories` param to `getDirectoryPath` and `getDirectoryPaths` to control the visibility of the New Folder button in file dialogs on supported platforms.


This should not be describing an exact UI element, because this layer has no control over what the specific UI is.

Ah, I get it now. It makes sense.
I will describe the behavior instead.

stuartmorgan-g · 2025-10-10T15:33:56Z

...le_selector/file_selector_platform_interface/test/file_selector_platform_interface_test.dart

+  });
+
+  group('getDirectoryPathWithOptions', () {
+    test('Should throw unimplemented exception', () async {


Here and below: that's not what we want to test for the new methods. The implementations of the new methods should not throw UnimplementedError, because that would break backward compatibility when the app-facing package change lands. They must call the deprecated methods, and that's what the test should be testing.

I see.
I didn't even realize the getSaveLocation test was doing exactly what you described.
I'll update the mentioned tests to check if the deprecated methods were called.

stuartmorgan-g · 2025-11-11T14:06:07Z

@danferreira Please proceed with splitting out a PR with all the platform implementations now, and we can get that landed next (see the note in step 5 here).

danferreira · 2025-11-16T16:32:47Z

@danferreira Please proceed with splitting out a PR with all the platform implementations now, and we can get that landed next (see the note in step 5 here).

Thanks for the direction @stuartmorgan-g
I ended up making changes on platforms that doesnt support this new parameter (web, windows and android) creating a lot of "noise"

Should I update all other platforms on the new PR or only the ones affected (macos, linux)?
PR with macos and linux platform integrations: #10443

I noticed platform interface for iOS is a bit outdated compared to the others so I assume we only update when needed/is used, right?

…0443) Updates macos and linux `file_selector` platforms to implement the new `canCreateDirectories` parameter from platform interface Until now, only macos and linux are able to override this parameter This is the "platform implementations" step for #9965 Part of: flutter/flutter#141339 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

stuartmorgan-g

LGTM, thanks for getting this updated so quickly!

…ers button is visible in the file dialog (flutter/packages#9965)

flutter/packages@e67b6be...e019cf9 2025-11-24 [email protected] [Android 16] Bump Packages to Robolectric 4.16 (flutter/packages#10492) 2025-11-24 [email protected] Roll Flutter from c8cfb2b to 3f553f6 (11 revisions) (flutter/packages#10510) 2025-11-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the test-dependencies group across 6 directories with 2 updates (flutter/packages#10500) 2025-11-22 [email protected] Roll Flutter from d438df3 to c8cfb2b (21 revisions) (flutter/packages#10494) 2025-11-21 [email protected] [webview_flutter] Update Pigeon for Kotlin 1.8 compat (flutter/packages#10486) 2025-11-21 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the gradle-plugin group across 19 directories with 1 update (flutter/packages#10456) 2025-11-21 [email protected] [file_selector] Add parameter to control whether the new folders button is visible in the file dialog (flutter/packages#9965) 2025-11-21 [email protected] Roll Flutter from 9f383e0 to d438df3 (18 revisions) (flutter/packages#10491) 2025-11-21 [email protected] Roll Flutter (stable) from f5a8537 to 19074d1 (2 revisions) (flutter/packages#10489) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added p: file_selector platform-android platform-ios platform-linux platform-macos platform-web platform-windows labels Sep 6, 2025

danferreira marked this pull request as ready for review September 6, 2025 22:44

danferreira requested review from ditman, mboetger, stuartmorgan-g and vashworth as code owners September 6, 2025 22:44

stuartmorgan-g requested changes Sep 10, 2025

View reviewed changes

github-actions bot removed the platform-ios label Sep 11, 2025

danferreira requested a review from stuartmorgan-g September 11, 2025 04:32

stuartmorgan-g removed the request for review from ditman October 10, 2025 15:35

stuartmorgan-g reviewed Oct 10, 2025

View reviewed changes

stuartmorgan-g added triage-ios Should be looked at in iOS triage triage-android Should be looked at in Android triage labels Oct 10, 2025

danferreira force-pushed the file_selector-can-create-directories-param branch from cb4e65c to 0b3beb5 Compare October 22, 2025 00:08

danferreira requested review from Piinks, bkonyi, bparrishMines, camsim99, gmackall, mdebbar, parlough and tarrinneal as code owners October 22, 2025 00:08

github-actions bot added p: camera p: google_maps_flutter labels Oct 22, 2025

danferreira requested a review from robert-ancell as a code owner November 10, 2025 21:40

danferreira added 2 commits November 10, 2025 19:08

Undo deps versions update

148c25b

Fix tests to cover new api

4b67113

danferreira requested a review from stuartmorgan-g November 11, 2025 03:03

Merge branch 'main' into file_selector-can-create-directories-param

9f5de16

danferreira mentioned this pull request Nov 16, 2025

[file_selector] Implement canCreateDirectories on macos and linux #10443

Merged

11 tasks

danferreira added 3 commits November 21, 2025 13:32

Merge branch 'main' into file_selector-can-create-directories-param

6a723c4

Resolve conflicts with main branch

ac6b60d

Update macos and linux versions

8d69a60

github-actions bot removed platform-android platform-linux platform-web platform-windows labels Nov 21, 2025

Update min SDK versions to match dependencies

779c818

stuartmorgan-g approved these changes Nov 21, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 21, 2025

auto-submit bot merged commit 6a84a54 into flutter:main Nov 21, 2025
80 checks passed

danferreira deleted the file_selector-can-create-directories-param branch November 21, 2025 19:32

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025

6a84a54 [file_selector] Add parameter to control whether the new fold…

5848022

…ers button is visible in the file dialog (flutter/packages#9965)

engine-flutter-autoroll mentioned this pull request Nov 24, 2025

Roll Packages from e67b6be3f579 to fb5f02f1ebb0 (7 revisions) flutter/flutter#179017

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025

6a84a54 [file_selector] Add parameter to control whether the new fold…

b7fcc92

…ers button is visible in the file dialog (flutter/packages#9965)

engine-flutter-autoroll mentioned this pull request Nov 24, 2025

Roll Packages from e67b6be3f579 to 5c5b6c6653bc (8 revisions) flutter/flutter#179025

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 24, 2025

6a84a54 [file_selector] Add parameter to control whether the new fold…

3db42bd

…ers button is visible in the file dialog (flutter/packages#9965)

engine-flutter-autoroll mentioned this pull request Nov 24, 2025

Roll Packages from e67b6be3f579 to e019cf9fc411 (9 revisions) flutter/flutter#179035

Merged

[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

[file_selector] Add parameter to control whether the new folders button is visible in the file dialog #9965

Uh oh!

Conversation

danferreira commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danferreira Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Nov 11, 2025

Uh oh!

danferreira commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

danferreira commented Sep 6, 2025 •

edited

Loading

danferreira Sep 11, 2025 •

edited

Loading

danferreira commented Nov 16, 2025 •

edited

Loading