[camera_avfoundation] Implementation swift migration - part 13 #9930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the updateOrientation and setCaptureSessionPreset methods from Objective-C to Swift, and subsequently removes the now-obsolete FLTCam class. This is a great step forward in the Swift migration. The implementation looks solid, and I have a couple of minor suggestions to enhance code safety and adopt more idiomatic Swift patterns.
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Sep 3, 2025
| ## 0.9.21+3 | ||
|
|
||
| * Migrates `updateOrientation` and `setCaptureSessionPreset` methods to Swift. | ||
| * Removes `FLTCam` class. |
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part13
branch
2 times, most recently
from
e84e04c to
aeae649
Compare
Contributor
Author
|
@hellohuanlin take a look at this PR again when you have a moment pls |
RobertOdrowaz
added
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/9930, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
auto-submit
bot
removed
the
autosubmit
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part13
branch
from
aeae649 to
9f6e214
Compare
Contributor
Author
|
Test exemption reason: refactors with no semantic change (e.g. null safety migrations) |
Collaborator
|
test-exempt: code refactor with no semantic change |
Collaborator
|
Sorry, this will require a merge to re-delete the deleted files; I just landed a mass change that slightly altered the license header of all code files in the repository, which is why there's a conflict here now. |
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part13
branch
from
9f6e214 to
bafa2c5
Compare
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 30, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 30, 2025
flutter/packages@34eec78...287739d 2025-09-29 [email protected] Roll Flutter (stable) from d693b4b to ac4e799 (4 revisions) (flutter/packages#10124) 2025-09-29 [email protected] Fix CODEOWNERS error (flutter/packages#10127) 2025-09-29 [email protected] [file_selector] Update Pigeon in Android implementation (flutter/packages#10126) 2025-09-29 [email protected] [In_app_purchase_storekit] Do not throw PigeonError when a transaction is pending / cancelled / unverified (flutter/packages#9627) 2025-09-29 [email protected] [video_player] Separate texture ID on Android (flutter/packages#10029) 2025-09-29 [email protected] Roll Flutter from 6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125) 2025-09-29 [email protected] [camera_android_camerax] Fix NV21 Format (flutter/packages#10022) 2025-09-29 [email protected] Manual roll Flutter from b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116) 2025-09-29 [email protected] [camera_avfoundation] Implementation swift migration - part 13 (flutter/packages#9930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
flutter/packages@34eec78...287739d 2025-09-29 [email protected] Roll Flutter (stable) from d693b4b to ac4e799 (4 revisions) (flutter/packages#10124) 2025-09-29 [email protected] Fix CODEOWNERS error (flutter/packages#10127) 2025-09-29 [email protected] [file_selector] Update Pigeon in Android implementation (flutter/packages#10126) 2025-09-29 [email protected] [In_app_purchase_storekit] Do not throw PigeonError when a transaction is pending / cancelled / unverified (flutter/packages#9627) 2025-09-29 [email protected] [video_player] Separate texture ID on Android (flutter/packages#10029) 2025-09-29 [email protected] Roll Flutter from 6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125) 2025-09-29 [email protected] [camera_android_camerax] Fix NV21 Format (flutter/packages#10022) 2025-09-29 [email protected] Manual roll Flutter from b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116) 2025-09-29 [email protected] [camera_avfoundation] Implementation swift migration - part 13 (flutter/packages#9930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@34eec78...287739d 2025-09-29 [email protected] Roll Flutter (stable) from d693b4b to ac4e799 (4 revisions) (flutter/packages#10124) 2025-09-29 [email protected] Fix CODEOWNERS error (flutter/packages#10127) 2025-09-29 [email protected] [file_selector] Update Pigeon in Android implementation (flutter/packages#10126) 2025-09-29 [email protected] [In_app_purchase_storekit] Do not throw PigeonError when a transaction is pending / cancelled / unverified (flutter/packages#9627) 2025-09-29 [email protected] [video_player] Separate texture ID on Android (flutter/packages#10029) 2025-09-29 [email protected] Roll Flutter from 6cc976e to 96fe3b3 (32 revisions) (flutter/packages#10125) 2025-09-29 [email protected] [camera_android_camerax] Fix NV21 Format (flutter/packages#10022) 2025-09-29 [email protected] Manual roll Flutter from b1a28bc to 6cc976e (4 revisions) (flutter/packages#10116) 2025-09-29 [email protected] [camera_avfoundation] Implementation swift migration - part 13 (flutter/packages#9930) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the last chunk of
FLTCamclass to Swift:updateOrientationsetCaptureSessionPresetFLTCamclassPre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3