[animations] ✨ Make OpenContainerState public
#9924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @AlexV525! Just came across this, thanks for contributing. :) Drafts usually do not enter review queues, so please do mark this ready for review when it is. It looks like there are a couple of failures right now. |
Member
Author
@Piinks Thanks for the ping! I just don't have a good time to write some tests for it recently. :D I shall come back in the next few days. |
hannah-hyj
reviewed
Oct 8, 2025
| class _OpenContainerState<T> extends State<OpenContainer<T?>> { | ||
| /// State for a [OpenContainer]. | ||
| /// | ||
| /// Can [openContainer] explicitly or via a tap when |
Member
There was a problem hiding this comment.
/// The [openContainer] can be triggered either by:
/// 1. Explicitly calling [openContainer] from [OpenContainerState]
/// 2. By tapping the [OpenContainer] widget itself, if [OpenContainer.tappable] is true.
hannah-hyj
approved these changes
Oct 8, 2025
Member
hannah-hyj
left a comment
hannah-hyj
left a comment
There was a problem hiding this comment.
This PR looks good to me, thank you for your contribution!
Clarified documentation for triggering the openContainer method.
AlexV525
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 9, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 9, 2025
flutter/packages@260f381...0b41de3 2025-10-09 [email protected] [animations] ✨ Make `OpenContainerState` public (flutter/packages#9924) 2025-10-08 [email protected] Roll Flutter from 908012d to e11e2c1 (39 revisions) (flutter/packages#10192) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@260f381...0b41de3 2025-10-09 [email protected] [animations] ✨ Make `OpenContainerState` public (flutter/packages#9924) 2025-10-08 [email protected] Roll Flutter from 908012d to e11e2c1 (39 revisions) (flutter/packages#10192) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea of this PR is now users can now call
openContainerexternally through a given key.(Possibly) Fixes flutter/flutter#82133 since now we can combine custom gesture recognition with the method.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3