[google_fonts] Improve CONTRIBUTING and generator README #9917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request consolidates and improves the documentation for the google_fonts package generator. It achieves this by removing the package-level CONTRIBUTING.md and moving its contents into an expanded generator/README.md. The changes make the instructions for running the generator clearer and more discoverable. I've provided a couple of suggestions to further improve the wording and fix a broken link in the new README file.
Member
Author
|
exempted from CHANGELOG update and version change: local development |
guidezpl
added
override: no versioning needed
guidezpl
changed the title
Piinks
reviewed
Aug 28, 2025
| regenerate most Dart code (e.g. `GoogleFonts` class), and [families_supported](./families_supported). | ||
|
|
||
| 1. Navigate to the root directory of this project. | ||
| Note: Googlers only, pending b/280786655, there is an additional prerequisite step required of the Google Fonts team |
Contributor
There was a problem hiding this comment.
Where is this additional step documented?
Member
Author
There was a problem hiding this comment.
I don't think it is, just something I know. In the status update, there's a link to a manual version of the process, the long term idea being to remove the need for this. The bug assignee has all the info
Contributor
There was a problem hiding this comment.
I am not sure I follow. So when we go to run the generator script, we contact the assigned person on that bug to complete another step first?
Member
Author
There was a problem hiding this comment.
Right. So, the generator looks for the latest directory of fonts. New versions of that directory are created (currently, with a manual step) by that Googler.
stuartmorgan-g
approved these changes
Aug 29, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with one nit.
Piinks
reviewed
Sep 4, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 5, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 5, 2025
flutter/packages@98580c6...cab2ac2 2025-09-05 [email protected] Roll Flutter from 6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962) 2025-09-04 [email protected] [google_fonts] Improve CONTRIBUTING and generator README (flutter/packages#9917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@98580c6...cab2ac2 2025-09-05 [email protected] Roll Flutter from 6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962) 2025-09-04 [email protected] [google_fonts] Improve CONTRIBUTING and generator README (flutter/packages#9917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
flutter/packages@98580c6...cab2ac2 2025-09-05 [email protected] Roll Flutter from 6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962) 2025-09-04 [email protected] [google_fonts] Improve CONTRIBUTING and generator README (flutter/packages#9917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danferreira
pushed a commit
to danferreira/packages
that referenced
this pull request
Oct 22, 2025
Apply feedback from flutter#9895 Note: the `families_diff` file created by the generator should suffice in writing CHANGELOG updates ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@98580c6...cab2ac2 2025-09-05 [email protected] Roll Flutter from 6b18740 to 87d5b75 (88 revisions) (flutter/packages#9962) 2025-09-04 [email protected] [google_fonts] Improve CONTRIBUTING and generator README (flutter/packages#9917) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply feedback from #9895
Note: the
families_difffile created by the generator should suffice in writing CHANGELOG updatesPre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3