[google_fonts] Initial import #9895

stuartmorgan-g · 2025-08-27T14:41:37Z

Initial import of google_fonts

As with previous package imports, this is a history graft that will be landed as a merge rather than a squash, to preserve commit history. My changes are all visible as follow-up commits to the initial merge commit, but to summarize:

Updated the package metadata (version, changelog, repo links, etc.)
Updated the min SDK version to follow our policy
Autoformated for the new SDK version
Fixed (or in some cases, ignored) violations of our stricter analysis options
Adopted the README code excerpts system
Adopted the standard repo license format, per repo policy
Removed the use of cider to auto-generate changelog updates during generation, to remove the third-party dependency
Added a suffix to the generated code, and adds a repo-level rule to ignore that suffix during analysis
Added repo-level allowance for protobuf (google-owned) and mustache_template (pinned, with allowance explanation)
Removed example/test/unit_test.dart, which failed in CI (it wasn't being run in the source repo's CI) and appeared to be demonstrating an anti-pattern (trying to load fonts via the network in a unit test).
Updated example/android/ to use the new build style

Pre-Review Checklist

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

…lutter#366) Bumps [path_provider](https://github.com/flutter/packages/tree/main/packages/path_provider) from 2.0.12 to 2.0.13. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/path_provider-v2.0.13/packages/path_provider) --- updated-dependencies: - dependency-name: path_provider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [cider](https://github.com/f3ath/cider) from 0.1.3 to 0.1.5. - [Release notes](https://github.com/f3ath/cider/releases) - [Changelog](https://github.com/f3ath/cider/blob/master/CHANGELOG.md) - [Commits](f3ath/cider@0.1.3...0.1.5) --- updated-dependencies: - dependency-name: cider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…lutter#375) Bumps [path_provider](https://github.com/flutter/packages/tree/main/packages/path_provider) from 2.0.13 to 2.0.14. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/path_provider-v2.0.14/packages/path_provider) --- updated-dependencies: - dependency-name: path_provider dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [mockito](https://github.com/dart-lang/mockito) from 5.3.2 to 5.4.0. - [Release notes](https://github.com/dart-lang/mockito/releases) - [Changelog](https://github.com/dart-lang/mockito/blob/master/CHANGELOG.md) - [Commits](dart-lang/mockito@5.3.2...5.4.0) --- updated-dependencies: - dependency-name: mockito dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

gemini-code-assist

Code Review

This pull request introduces the google_fonts package into the repository. The changes include adding the package source code, an example application, generator scripts, and updating repository-level configuration files like CODEOWNERS, dependabot.yml, and labeler.yml. My review found a couple of issues in the generator script and its documentation that should be addressed. Specifically, the generator uses an insecure HTTP URL to fetch font data, and the generator's README contains outdated information about a removed dependency.

gemini-code-assist · 2025-08-27T14:43:12Z

packages/google_fonts/generator/generator.dart

+
+  Uri url(int directoryVersion) {
+    final String paddedVersion = directoryVersion.toString().padLeft(3, '0');
+    return Uri.parse('http://fonts.gstatic.com/s/f/directory$paddedVersion.pb');


The URL for fetching the font directory protobuf file uses http instead of https. Using an insecure connection can expose the generator to man-in-the-middle attacks. Please update the URL to use https.

Suggested change

return Uri.parse('http://fonts.gstatic.com/s/f/directory$paddedVersion.pb');

return Uri.parse('https://fonts.gstatic.com/s/f/directory$paddedVersion.pb');

Fixed, as this only affects local development, and seems like a very good change.

gemini-code-assist · 2025-08-27T14:43:12Z

packages/google_fonts/generator/README.md

+Generates the `GoogleFonts` class, list of supported families, and updates CHANGELOG.md and pubspec.yaml.
+
+1. Navigate to the root directory of this project.
+2. `dart pub global activate cider`
+3. `dart generator/generator.dart`


The PR description states that the cider dependency was removed, but this README still instructs users to install and use it. Please update the documentation to reflect the current generator process.

guidezpl · 2025-08-27T15:34:56Z

packages/google_fonts/CONTRIBUTING.md

@@ -0,0 +1,8 @@
+## Updating the fonts
+
+If you notice fonts that are on [fonts.google.com](https://fonts.google.com) that do not appear in


This file feels somewhat redundant with generator/README.md

https://github.com/material-foundation/flutter-packages/blob/main/packages/google_fonts/CONTRIBUTING.md

The goal of the import PR is to import the code as it was. The only reason it has any additional changes is that it has to be updated to follow all the repo conventions that are CI-enforced.

Maintainers are welcome to rewrite the contributor docs and generator README in future PRs, but for now the changes to the docs are just the ones that are the direct result of enforcing repo conventions (e.g., removing references to cider because I removed cider because it's a third-party dependency).

guidezpl · 2025-08-27T15:37:42Z

packages/google_fonts/generator/generator.dart

  }
-
-  // Use cider to update CHANGELOG.md and pubspec.yaml.
-  Future<void> updateChangelogAndPubspec() async {


can you log output to console to make CHANGELOG updates easier to write?

In this repo we write changelog entries as part of the pull request.

I understand. The list of fonts can still be output by the generator to help writing the CHANGELOG update

Adding new code generator logic is out of scope in this PR. Maintainers can decide how they want to manage CHANGELOG updates and update the script accordingly in follow-ups.

guidezpl · 2025-08-27T15:40:37Z

packages/google_fonts/README.md

 ### Visual font swapping
 To avoid visual font swaps that occur when a font is loading, use [FutureBuilder](https://api.flutter.dev/flutter/widgets/FutureBuilder-class.html) and [GoogleFonts.pendingFonts()](https://pub.dev/documentation/google_fonts/latest/google_fonts/GoogleFonts/pendingFonts.html).

-See the [example app](https://github.com/material-foundation/flutter-packages/blob/main/packages/google_fonts/example/lib/main.dart).


this should still link to source code, no?

It could, but that pub.dev page is the contents of example/lib/main.dart.

Piinks · 2025-08-27T15:42:26Z

How can I help @stuartmorgan-g?

Looks like the extra analysis options in the example directory are what the analyzer is unhappy with.
The repo checks are failing on a couple of things, checking in files from the .gitignore, not have gradle configured correctly, and not passing the publishability check.

packages/google_fonts/example/analysis_options.yaml

guidezpl · 2025-08-27T15:48:10Z

I'll deal with the 2 missing CLA entries, one from a Google-owned bot, and the other from a Xoogler

stuartmorgan-g · 2025-08-27T16:05:45Z

Looks like the extra analysis options in the example directory are what the analyzer is unhappy with.
The repo checks are failing on a couple of things, checking in files from the .gitignore, not have gradle configured correctly, and not passing the publishability check.

I just didn't remember to run all of the checks locally, so missed some conformance changes.

stuartmorgan-g · 2025-08-27T16:06:35Z

I'll deal with the 2 missing CLA entries, one from a Google-owned bot, and the other from a Xoogler

There's no need; I'll override the CLA check once the PR is ready to land. The source repository enforced the same CLA checks, which is a valid override reason.

esouthren · 2025-08-27T16:31:07Z

Xoogler checking in :) CLA signed.

Piinks

LGTM

- Update repo metadata - Update pubspec.yaml to follow repo conventions - Remove cider dependency - Remove git-ignored files - Use a suffix for generated files - Switch to repo analysis options and fix violations - Standardize licenses - Update links and docs to match changes - Reformat CHANGELOG - Update links - Adopt readme excerpts - Update min Flutter SDK version - Autoformat - Switch font download links to https - Update Android exmaple/ Gradle files - Delete example/unit_test.dart - Annotate test files that are not web-compatible - Bump minimum plugin_platform_interface version to satisfy downgrade analysis

stuartmorgan-g · 2025-08-27T19:21:09Z

Force-pushed to squash all of my incremental adjustment PRs, so they don't all become individual commits in repo history (since this won't be a squash commit).

flutter/packages@86fbeec...141d8e3 2025-08-28 [email protected] Roll Flutter from c65f01d to da5523a (26 revisions) (flutter/packages#9903) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/local_auth/local_auth_android/android (flutter/packages#9916) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9915) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#9914) 2025-08-27 [email protected] [google_fonts] Initial import (flutter/packages#9895) 2025-08-27 [email protected] [camera_android_camerax] Support NV21 (flutter/packages#9853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Apply feedback from #9895 Note: the `families_diff` file created by the generator should suffice in writing CHANGELOG updates ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

flutter/packages@86fbeec...141d8e3 2025-08-28 [email protected] Roll Flutter from c65f01d to da5523a (26 revisions) (flutter/packages#9903) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/local_auth/local_auth_android/android (flutter/packages#9916) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9915) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#9914) 2025-08-27 [email protected] [google_fonts] Initial import (flutter/packages#9895) 2025-08-27 [email protected] [camera_android_camerax] Support NV21 (flutter/packages#9853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Apply feedback from flutter#9895 Note: the `families_diff` file created by the generator should suffice in writing CHANGELOG updates ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

flutter/packages@86fbeec...141d8e3 2025-08-28 [email protected] Roll Flutter from c65f01d to da5523a (26 revisions) (flutter/packages#9903) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/local_auth/local_auth_android/android (flutter/packages#9916) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9915) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#9914) 2025-08-27 [email protected] [google_fonts] Initial import (flutter/packages#9895) 2025-08-27 [email protected] [camera_android_camerax] Support NV21 (flutter/packages#9853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

guidezpl and others added 30 commits February 1, 2023 12:50

move google_fonts to packages subdirectory

c3c9196

tweak ignore files

004bd53

update links, team reviewers

102223e

Update CONTRIBUTING.md links and info

9996587

fix pubspec link

5c54a87

Create CONTRIBUTING.md

c477a39

Rename google_fonts updating GitHub workflow

65f11f4

update google_fonts contributing

eff6881

add support for global analysis options

080151b

pub get

6518eed

add cider to dev_dependencies

7686833

use cider for all CHANGELOGs

2b72e35

pub get

63420a5

remove cider bumping and releasing from google_fonts workflow

2f7c7e3

Update generator.dart

9651b97

bump google_fonts to 4.0.2

062896a

Update generator.dart

a5f083c

[all] add pubspec issue_tracker & screenshots

4c6ed59

[all] update example apps

1fbac80

fix issue link

a1c95d7

[all] bump versions

d355c0e

Fix URL for 'example/test' (flutter#389)

47d1216

update pubspecs

1bac036

replace deprecations

527fddb

bump google_fonts to 4.0.4

eb11718

format

687e020

github-actions bot added platform-macos platform-web platform-windows labels Aug 27, 2025

gemini-code-assist bot reviewed Aug 27, 2025

View reviewed changes

guidezpl reviewed Aug 27, 2025

View reviewed changes

packages/google_fonts/example/analysis_options.yaml Outdated Show resolved Hide resolved

Piinks approved these changes Aug 27, 2025

View reviewed changes

guidezpl approved these changes Aug 27, 2025

View reviewed changes

stuartmorgan-g force-pushed the google-fonts-import branch from 7ac8cc8 to ffd7a9d Compare August 27, 2025 19:18

stuartmorgan-g merged commit bff47a3 into flutter:main Aug 27, 2025
80 checks passed

github-actions bot added the p: google_fonts label Aug 27, 2025

guidezpl mentioned this pull request Aug 28, 2025

[google_fonts] Improve CONTRIBUTING and generator README #9917

Merged

11 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2025

bff47a3 [google_fonts] Initial import (flutter/packages#9895)

352ea99

engine-flutter-autoroll mentioned this pull request Aug 28, 2025

Roll Packages from 86fbeecb7b4f to 141d8e304419 (6 revisions) flutter/flutter#174645

Merged

	return Uri.parse('http://fonts.gstatic.com/s/f/directory$paddedVersion.pb');
	return Uri.parse('https://fonts.gstatic.com/s/f/directory$paddedVersion.pb');

		@@ -0,0 +1,8 @@
		## Updating the fonts

		If you notice fonts that are on [fonts.google.com](https://fonts.google.com) that do not appear in

[google_fonts] Initial import #9895

[google_fonts] Initial import #9895

Uh oh!

Conversation

stuartmorgan-g commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Aug 27, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Piinks commented Aug 27, 2025

Uh oh!

Uh oh!

guidezpl commented Aug 27, 2025

Uh oh!

stuartmorgan-g commented Aug 27, 2025

Uh oh!

stuartmorgan-g commented Aug 27, 2025

Uh oh!

esouthren commented Aug 27, 2025

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Aug 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

stuartmorgan-g commented Aug 27, 2025 •

edited

Loading