[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868

nozomemein · 2025-08-22T03:06:20Z

Description

Fixes an issue where deep links with empty paths (e.g., https://example.com) lose their scheme and authority information during Android Cold Start.

This PR fixes flutter/flutter#174249

Detailed reproduction steps, environment information, and code sample are provided in the linked issue.

Problem

On Android Cold Start, if the initial deep link has no path (https://example.com),
_effectiveInitialLocation incorrectly creates a new Uri with only /? instead of preserving scheme and authority.
This results in the router receiving a relative path instead of the full deep link URL.

Solution

Use Uri.replace(path: '/') instead of creating a new Uri, so that the original scheme and authority are preserved.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

google-cla · 2025-08-22T03:06:24Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

chunhtai

LGTM

chunhtai · 2025-08-25T16:53:00Z

packages/go_router/lib/src/router.dart

      WidgetsBinding.instance.platformDispatcher.defaultRouteName,
    );
    if (platformDefaultUri.hasEmptyPath) {
      // TODO(chunhtai): Clean up this once `RouteInformation.uri` is available


I think this todo is obsolete now, can you remove this todo?

deleted in the commit below!

84da17c

hannah-hyj

LGTM

nozomemein · 2025-09-15T04:28:31Z

@hannah-hyj @chunhtai
Appreciate the approval!
I see there is a merge conflict. The contributor guide notes it’s fine to leave conflicts until the end of review, but I’m happy to rebase and resolve them now if that helps move this forward.
Please let me know which you’d prefer, and if there are any remaining blockers before landing.

justinmc · 2025-09-16T22:22:13Z

@nozomemein Please go ahead and fix the merge conflict since this PR is already approved and otherwise ready to land. Thank you!

nozomemein · 2025-09-16T23:49:58Z

@justinmc
Thank you! Fixed the confilct!

…with empty path

packages/go_router/CHANGELOG.md

packages/go_router/pubspec.yaml

Piinks · 2025-09-23T22:30:01Z

Resolved changelog/pubspec conflicts, should be good to merge! 🤞

…losing scheme and authority. (flutter/packages#9868)

flutter/packages@3413b65...117bf63 2025-09-24 [email protected] [ci] Add update-release-info command suggestion when version check fails (flutter/packages#9834) 2025-09-24 [email protected] Manual roll Flutter from 9ff2767 to 4a04204 (28 revisions) (flutter/packages#10067) 2025-09-24 [email protected] Remove "All right reserved" from all files (flutter/packages#10066) 2025-09-24 [email protected] [google_sign_in] Implement `disconnect` for Android (flutter/packages#9991) 2025-09-24 [email protected] [camera_android] Remove references to third party `googlesamples/mlkit` code (flutter/packages#10056) 2025-09-23 [email protected] [go_router_builder] [in_app_purchase_storekit] Removes redundant arguments from annotations (flutter/packages#9964) 2025-09-23 [email protected] [go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. (flutter/packages#9868) 2025-09-23 [email protected] [go_router_builder] Proposal: add json support, custom string encoder/decoder (flutter/packages#8665) 2025-09-23 [email protected] [go_router] Fix ShellRoutes break iOS swipe back navigation (flutter/packages#9968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added the p: go_router label Aug 22, 2025

nozomemein marked this pull request as ready for review August 22, 2025 04:02

nozomemein requested a review from chunhtai as a code owner August 22, 2025 04:02

nozomemein mentioned this pull request Aug 23, 2025

Android Cold Start deep link with empty path loses scheme and authority flutter/flutter#174249

Closed

chunhtai approved these changes Aug 25, 2025

View reviewed changes

chunhtai requested a review from hannah-hyj August 25, 2025 16:53

hannah-hyj approved these changes Sep 4, 2025

View reviewed changes

nozomemein force-pushed the fix/go-router-android-coldstart-empty-path branch 2 times, most recently from da35f7f to cdab8c5 Compare September 16, 2025 23:16

nozomemein added 2 commits September 22, 2025 12:22

fix: preserve scheme and authority for Android Cold Start deep links …

ec8c7ad

…with empty path

rm the obsolete todo comments

799ec60

nozomemein force-pushed the fix/go-router-android-coldstart-empty-path branch from cdab8c5 to 799ec60 Compare September 22, 2025 03:22

Piinks reviewed Sep 23, 2025

View reviewed changes

packages/go_router/CHANGELOG.md Outdated Show resolved Hide resolved

Piinks reviewed Sep 23, 2025

View reviewed changes

packages/go_router/pubspec.yaml Outdated Show resolved Hide resolved

Piinks added 3 commits September 23, 2025 17:28

Update packages/go_router/pubspec.yaml

d3d3105

Update packages/go_router/CHANGELOG.md

11ecd2e

Merge branch 'main' into fix/go-router-android-coldstart-empty-path

7c6fe98

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 23, 2025

auto-submit bot merged commit a7a5ec8 into flutter:main Sep 23, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2025

a7a5ec8 [go_router] Fix Android Cold Start deep link with empty path …

c7fe601

…losing scheme and authority. (flutter/packages#9868)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Packages from 3413b65fdde1 to 2fe85dd0f730 (8 revisions) flutter/flutter#175933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 24, 2025

a7a5ec8 [go_router] Fix Android Cold Start deep link with empty path …

b8ef9ce

…losing scheme and authority. (flutter/packages#9868)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Packages from 3413b65fdde1 to 117bf639ec3a (9 revisions) flutter/flutter#175935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868

[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868

Uh oh!

nozomemein commented Aug 22, 2025 •

edited

Loading

Uh oh!

google-cla bot commented Aug 22, 2025

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Aug 25, 2025

Uh oh!

nozomemein Aug 25, 2025

Uh oh!

hannah-hyj left a comment

Uh oh!

nozomemein commented Sep 15, 2025

Uh oh!

justinmc commented Sep 16, 2025

Uh oh!

nozomemein commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

Piinks commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868

[go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. #9868

Uh oh!

Conversation

nozomemein commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Problem

Solution

Pre-Review Checklist

Footnotes

Uh oh!

google-cla bot commented Aug 22, 2025

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

nozomemein Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

hannah-hyj left a comment

Choose a reason for hiding this comment

Uh oh!

nozomemein commented Sep 15, 2025

Uh oh!

justinmc commented Sep 16, 2025

Uh oh!

nozomemein commented Sep 16, 2025

Uh oh!

Uh oh!

Uh oh!

Piinks commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nozomemein commented Aug 22, 2025 •

edited

Loading