[camera_android_camerax] Support NV21 #9853

camsim99 · 2025-08-19T23:33:12Z

Implements NV21 support for image streaming.

Also bumps the CameraX version to 1.5.0-rc01! To do this, I needed to (1) bump the minimum SDK version to 23 and (2) modify a couple of unrelated tests.

Fixes flutter/flutter#145961.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

camsim99 · 2025-08-26T18:58:26Z

packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart

I notice that the diff here is a bit funky....it might be easier to look at the file itself and search for the tests that I modified there. I really only:

Modified tests that tested logic previously in createCamera that I moved to initializeCamers

Added createCamera and initializeCamera properly set filter for resolution preset for non-video capture use cases and initializeCamera sets camera state observer as expected.

packages/camera/camera_android_camerax/android/build.gradle

Co-authored-by: jesswrd <[email protected]>

…amx_nv21_2

FantaMagier · 2025-08-28T08:19:08Z

@camsim99 We should adjust the instructions on how to specifically convert from yuv format to nv21. Since the image stream still returns yuv with nv21 formatting. Or rather, I don't understand it yet haha.

flutter/packages@86fbeec...141d8e3 2025-08-28 [email protected] Roll Flutter from c65f01d to da5523a (26 revisions) (flutter/packages#9903) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/local_auth/local_auth_android/android (flutter/packages#9916) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9915) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#9914) 2025-08-27 [email protected] [google_fonts] Initial import (flutter/packages#9895) 2025-08-27 [email protected] [camera_android_camerax] Support NV21 (flutter/packages#9853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

camsim99 · 2025-08-28T17:02:35Z

@FantaMagier My understanding is that there is no further conversion work to do. The Android docs for the NV21 format that image streaming uses say:

All ImageProxy sent to analyze will be in YUV_420_888 format with their image data formatted in NV21.

I updated the the README to note that the data is actually in NV21 (see section), but let me know if this is unclear or if any other info in the Android docs would be useful to put in the README. Also if my understanding is incorrect, please let me know!

FantaMagier · 2025-09-01T07:53:05Z

@camsim99 Okay, I understand, thanks for explaining! The strange thing is that I still can't transfer it with the Flutter ML Kit Package.

camsim99 · 2025-09-02T17:29:36Z

@FantaMagier Can you open an issue for this with a minimal repro? I do want to make sure that use case works, so happy to follow up with you there.

#9853 bumped it to 23, so updating the README. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

pfistnerm · 2025-09-03T13:54:53Z

@FantaMagier My understanding is that there is no further conversion work to do. The Android docs for the NV21 format that image streaming uses say:

All ImageProxy sent to analyze will be in YUV_420_888 format with their image data formatted in NV21.

I updated the the README to note that the data is actually in NV21 (see section), but let me know if this is unclear or if any other info in the Android docs would be useful to put in the README. Also if my understanding is incorrect, please let me know!

This is very unfortunate. I hoped to fix the issue of google_mlkit_barcode_scanning with this but since the format group is still YUV_420_888, ml-kit throws the error PlatformException(InputImageConverterError, ImageFormat is not supported., null, null).

in the ml-kit example here it says:

If you are using the Camera plugin make sure to configure your CameraController to only use ImageFormatGroup.nv21 for Android and ImageFormatGroup.bgra8888 for iOS.

flutter/packages@86fbeec...141d8e3 2025-08-28 [email protected] Roll Flutter from c65f01d to da5523a (26 revisions) (flutter/packages#9903) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/local_auth/local_auth_android/android (flutter/packages#9916) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#9915) 2025-08-28 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.espresso:espresso-core from 3.6.1 to 3.7.0 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#9914) 2025-08-27 [email protected] [google_fonts] Initial import (flutter/packages#9895) 2025-08-27 [email protected] [camera_android_camerax] Support NV21 (flutter/packages#9853) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

add base changes and start test changes

c4629c2

github-actions bot added p: camera platform-android labels Aug 19, 2025

camsim99 mentioned this pull request Aug 19, 2025

[camera_android_camerax] Add support for NV21 image format #9644

Closed

11 tasks

camsim99 changed the title ~~[camera_android_camerax Support NV21.~~ [camera_android_camerax] Support NV21 Aug 25, 2025

camsim99 added 7 commits August 25, 2025 15:51

Fix existing tests

60bb085

fix analyze and add test for change

fbce588

fix preview tests

a9fe070

bump version

955085b

reformat java files

b74d9d0

fix java tests, format

3541c4b

self review

f1de1b7

camsim99 commented Aug 26, 2025

View reviewed changes

camsim99 marked this pull request as ready for review August 26, 2025 18:58

camsim99 requested review from a team and jesswrd August 26, 2025 18:59

jesswrd approved these changes Aug 26, 2025

View reviewed changes

packages/camera/camera_android_camerax/android/build.gradle Outdated Show resolved Hide resolved

camsim99 and others added 7 commits August 27, 2025 09:24

Update packages/camera/camera_android_camerax/android/build.gradle

21e0b86

Co-authored-by: jesswrd <[email protected]>

format

a1b5ee3

Merge remote-tracking branch 'refs/remotes/origin/camx_nv21_2' into c…

8912533

…amx_nv21_2

fixes...oops

530e973

self review +add changelog note

94c5bcd

Merge remote-tracking branch 'upstream/main' into camx_nv21_2

cf1c227

format ktl

8fffdcd

camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 27, 2025

auto-submit bot merged commit c905585 into flutter:main Aug 27, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 28, 2025

c905585 [camera_android_camerax] Support NV21 (flutter/packages#9853)

b195551

engine-flutter-autoroll mentioned this pull request Aug 28, 2025

Roll Packages from 86fbeecb7b4f to 141d8e304419 (6 revisions) flutter/flutter#174645

Merged

camsim99 mentioned this pull request Sep 2, 2025

[camera_android_camerax] Update Android minimum SDK version #9945

Merged

11 tasks

FantaMagier mentioned this pull request Sep 4, 2025

CameraX supports nv21 but as yuv420 flutter-ml/google_ml_kit_flutter#802

Closed

smallTrogdor mentioned this pull request Sep 29, 2025

scanner crashes with ImageFormat error on latest mlkit versions on Android SchweizerischeBundesbahnen/data-scanner-flutter#9

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[camera_android_camerax] Support NV21 #9853

[camera_android_camerax] Support NV21 #9853

Uh oh!

camsim99 commented Aug 19, 2025 •

edited

Loading

Uh oh!

camsim99 Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

FantaMagier commented Aug 28, 2025

Uh oh!

camsim99 commented Aug 28, 2025

Uh oh!

FantaMagier commented Sep 1, 2025

Uh oh!

camsim99 commented Sep 2, 2025

Uh oh!

pfistnerm commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[camera_android_camerax] Support NV21 #9853

[camera_android_camerax] Support NV21 #9853

Uh oh!

Conversation

camsim99 commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

camsim99 Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FantaMagier commented Aug 28, 2025

Uh oh!

camsim99 commented Aug 28, 2025

Uh oh!

FantaMagier commented Sep 1, 2025

Uh oh!

camsim99 commented Sep 2, 2025

Uh oh!

pfistnerm commented Sep 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camsim99 commented Aug 19, 2025 •

edited

Loading