[go_router] Update generated output format #9817

stuartmorgan-g · 2025-08-15T13:46:57Z

The Dart 3.7+ formatter does not remove all blank lines in function calls split across multile lines, so the generated+formatted output no longer matched expetations once the example app was changed to use a minimum SDK of 3.7. This updates the example app's min SDK (thus updating the autoformatting of all of its code), and changes the code generator such that running the new formatter on the output has the same results as it did with the previous formatter.

Unblocks #9816

Pre-Review Checklist

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

The Dart 3.7+ formatter does not remove all blank lines in function calls split across multile lines, so the generated+formatted output no longer matched expetations once the example app was changed to use a minimum SDK of 3.7. This updates the example app, and changes the code generator such that running the new formatter on the output has the same results as it did with the previous formatter. Unblocks flutter#9816

gemini-code-assist

Code Review

This pull request updates the go_router_builder to be compatible with the new Dart 3.7+ formatter. The main changes are in the code generator to adjust the whitespace in the generated output. This prevents the new formatter from leaving unwanted blank lines. The PR also includes updates to the example applications, reformatting them with the new formatter and updating their minimum SDK constraint. The changes look good and achieve the stated goal. I have one suggestion to improve the readability of the code generator.

gemini-code-assist · 2025-08-15T13:49:14Z

packages/go_router_builder/lib/src/route_config.dart

+  String get routeConstructorParameters =>
+      'path: ${escapeDartString(path)},'
+      '${name != null ? 'name: ${escapeDartString(name!)},' : ''}'
+      '${caseSensitive ? '' : 'caseSensitive: $caseSensitive,'}'
+      '${parentNavigatorKey == null ? '' : 'parentNavigatorKey: $parentNavigatorKey,'}';


For better readability and maintainability, you could build the list of parameters using a List and then join them. This makes it easier to add or remove parameters in the future.

String get routeConstructorParameters { final List<String> params = <String>[ 'path: ${escapeDartString(path)}', if (name != null) 'name: ${escapeDartString(name!)}', if (!caseSensitive) 'caseSensitive: $caseSensitive', if (parentNavigatorKey != null) 'parentNavigatorKey: $parentNavigatorKey', ]; return '${params.join(', ')},'; }

@chunhtai Something to consider for future changes; I actually wrote it this way originally, and then noticed that other versions of this method used direct string concatenation so I switched to that for consistency to minimize churn in this PR. I think adopting list conditionals everywhere instead would be a good change.

chunhtai

LGTM

* main: (24 commits) Roll Flutter from 0a2906b81d5e to b3fb4c786d80 (5 revisions) (flutter#9840) Update repo for 3.35 stable release (flutter#9816) Roll Flutter from 52af7a504025 to 0a2906b81d5e (16 revisions) (flutter#9836) [image_picker] Updates min SDK to 3.29 (flutter#9830) [image_picker] Add the ability to pick multiple videos (flutter#9775) [image_picker] Add the ability to pick multiple videos - platform implementations (flutter#9818) [various] Updates min SDK for third_party/packages to 3.29 (flutter#9819) [vector_graphics] Updates min SDK to 3.29 (flutter#9820) [google_maps_flutter] Updates min SDK to 3.29 (flutter#9821) [video_player] Updates min SDK to 3.29 (flutter#9826) [shared_preferences] Updates min SDK to 3.29 (flutter#9829) [image_picker_ios] Add photo to simulator Photos library during test (flutter#9759) [interactive_media_ads] Updates `README` with information about enabling desugaring on Android (flutter#9790) [in_app_purchase] Updates min SDK to 3.29 (flutter#9825) Roll Flutter from f4334d27934b to 52af7a504025 (29 revisions) (flutter#9832) [go_router] Update generated output format (flutter#9817) [video_player] Move Android buffer updates to Dart (flutter#9771) [webview_flutter] Add support for payment requests on Android (flutter#9679) [vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix (flutter#9813) [url_launcher_ios] Fix test button text to work on iOS 26 (flutter#9766) ... # Conflicts: # packages/go_router_builder/CHANGELOG.md # packages/go_router_builder/example/lib/all_types.g.dart # packages/go_router_builder/example/lib/main.g.dart # packages/go_router_builder/example/lib/shell_route_with_keys_example.g.dart # packages/go_router_builder/example/lib/shell_route_with_observers_example.g.dart

…9817)

flutter/packages@5c52c55...953cae0 2025-08-19 [email protected] Add com.android.tools.build:gradle to dependabot gradle-plugin group (flutter/packages#9848) 2025-08-19 [email protected] [flutter_migrate] Remove source (flutter/packages#9847) 2025-08-18 [email protected] [go_router]: Add `RelativeGoRouteData` and `TypedRelativeGoRoute` (flutter/packages#9732) 2025-08-18 [email protected] Roll Flutter (stable) from edada7c to 20f8274 (1474 revisions) (flutter/packages#9837) 2025-08-18 [email protected] Roll Flutter from b3fb4c7 to 2265d94 (7 revisions) (flutter/packages#9845) 2025-08-18 [email protected] Disable SwiftPM for `xcode-analyze` (flutter/packages#9666) 2025-08-17 [email protected] Roll Flutter from 0a2906b to b3fb4c7 (5 revisions) (flutter/packages#9840) 2025-08-16 [email protected] Update repo for 3.35 stable release (flutter/packages#9816) 2025-08-16 [email protected] Roll Flutter from 52af7a5 to 0a2906b (16 revisions) (flutter/packages#9836) 2025-08-16 [email protected] [image_picker] Updates min SDK to 3.29 (flutter/packages#9830) 2025-08-16 [email protected] [image_picker] Add the ability to pick multiple videos (flutter/packages#9775) 2025-08-16 [email protected] [image_picker] Add the ability to pick multiple videos - platform implementations (flutter/packages#9818) 2025-08-16 [email protected] [various] Updates min SDK for third_party/packages to 3.29 (flutter/packages#9819) 2025-08-16 [email protected] [vector_graphics] Updates min SDK to 3.29 (flutter/packages#9820) 2025-08-16 [email protected] [google_maps_flutter] Updates min SDK to 3.29 (flutter/packages#9821) 2025-08-16 [email protected] [video_player] Updates min SDK to 3.29 (flutter/packages#9826) 2025-08-15 [email protected] [shared_preferences] Updates min SDK to 3.29 (flutter/packages#9829) 2025-08-15 [email protected] [image_picker_ios] Add photo to simulator Photos library during test (flutter/packages#9759) 2025-08-15 [email protected] [interactive_media_ads] Updates `README` with information about enabling desugaring on Android (flutter/packages#9790) 2025-08-15 [email protected] [in_app_purchase] Updates min SDK to 3.29 (flutter/packages#9825) 2025-08-15 [email protected] Roll Flutter from f4334d2 to 52af7a5 (29 revisions) (flutter/packages#9832) 2025-08-15 [email protected] [go_router] Update generated output format (flutter/packages#9817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

The Dart 3.7+ formatter does not remove all blank lines in function calls split across multile lines, so the generated+formatted output no longer matched expetations once the example app was changed to use a minimum SDK of 3.7. This updates the example app's min SDK (thus updating the autoformatting of all of its code), and changes the code generator such that running the new formatter on the output has the same results as it did with the previous formatter. Unblocks flutter#9816 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

flutter/packages@5c52c55...953cae0 2025-08-19 [email protected] Add com.android.tools.build:gradle to dependabot gradle-plugin group (flutter/packages#9848) 2025-08-19 [email protected] [flutter_migrate] Remove source (flutter/packages#9847) 2025-08-18 [email protected] [go_router]: Add `RelativeGoRouteData` and `TypedRelativeGoRoute` (flutter/packages#9732) 2025-08-18 [email protected] Roll Flutter (stable) from edada7c to 20f8274 (1474 revisions) (flutter/packages#9837) 2025-08-18 [email protected] Roll Flutter from b3fb4c7 to 2265d94 (7 revisions) (flutter/packages#9845) 2025-08-18 [email protected] Disable SwiftPM for `xcode-analyze` (flutter/packages#9666) 2025-08-17 [email protected] Roll Flutter from 0a2906b to b3fb4c7 (5 revisions) (flutter/packages#9840) 2025-08-16 [email protected] Update repo for 3.35 stable release (flutter/packages#9816) 2025-08-16 [email protected] Roll Flutter from 52af7a5 to 0a2906b (16 revisions) (flutter/packages#9836) 2025-08-16 [email protected] [image_picker] Updates min SDK to 3.29 (flutter/packages#9830) 2025-08-16 [email protected] [image_picker] Add the ability to pick multiple videos (flutter/packages#9775) 2025-08-16 [email protected] [image_picker] Add the ability to pick multiple videos - platform implementations (flutter/packages#9818) 2025-08-16 [email protected] [various] Updates min SDK for third_party/packages to 3.29 (flutter/packages#9819) 2025-08-16 [email protected] [vector_graphics] Updates min SDK to 3.29 (flutter/packages#9820) 2025-08-16 [email protected] [google_maps_flutter] Updates min SDK to 3.29 (flutter/packages#9821) 2025-08-16 [email protected] [video_player] Updates min SDK to 3.29 (flutter/packages#9826) 2025-08-15 [email protected] [shared_preferences] Updates min SDK to 3.29 (flutter/packages#9829) 2025-08-15 [email protected] [image_picker_ios] Add photo to simulator Photos library during test (flutter/packages#9759) 2025-08-15 [email protected] [interactive_media_ads] Updates `README` with information about enabling desugaring on Android (flutter/packages#9790) 2025-08-15 [email protected] [in_app_purchase] Updates min SDK to 3.29 (flutter/packages#9825) 2025-08-15 [email protected] Roll Flutter from f4334d2 to 52af7a5 (29 revisions) (flutter/packages#9832) 2025-08-15 [email protected] [go_router] Update generated output format (flutter/packages#9817) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan-g added 2 commits August 15, 2025 09:28

Autoformat

f5b292e

stuartmorgan-g requested a review from chunhtai as a code owner August 15, 2025 13:46

github-actions bot added the p: go_router_builder label Aug 15, 2025

stuartmorgan-g mentioned this pull request Aug 15, 2025

Update repo for 3.35 stable release #9816

Merged

gemini-code-assist bot reviewed Aug 15, 2025

View reviewed changes

Update excerpts

c6f1dc9

chunhtai approved these changes Aug 15, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025

auto-submit bot merged commit c75b87c into flutter:main Aug 15, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025

c75b87c [go_router] Update generated output format (flutter/packages#…

8c6b1dc

…9817)

engine-flutter-autoroll mentioned this pull request Aug 18, 2025

Roll Packages from 5c52c5545f54 to abb2e34ce2ba (17 revisions) flutter/flutter#173961

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025

c75b87c [go_router] Update generated output format (flutter/packages#…

f6dfa45

…9817)

engine-flutter-autoroll mentioned this pull request Aug 18, 2025

Roll Packages from 5c52c5545f54 to abb2e34ce2ba (17 revisions) flutter/flutter#173976

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 18, 2025

c75b87c [go_router] Update generated output format (flutter/packages#…

ab82fcd

…9817)

engine-flutter-autoroll mentioned this pull request Aug 18, 2025

Roll Packages from 5c52c5545f54 to d147ca0c8df5 (18 revisions) flutter/flutter#173980

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 19, 2025

c75b87c [go_router] Update generated output format (flutter/packages#…

ea04947

…9817)

engine-flutter-autoroll mentioned this pull request Aug 19, 2025

Roll Packages from 5c52c5545f54 to 953cae031cb7 (22 revisions) flutter/flutter#174040

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[go_router] Update generated output format #9817

[go_router] Update generated output format #9817

Uh oh!

stuartmorgan-g commented Aug 15, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Aug 15, 2025

Uh oh!

stuartmorgan-g Aug 15, 2025

Uh oh!

chunhtai left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[go_router] Update generated output format #9817

[go_router] Update generated output format #9817

Uh oh!

Conversation

stuartmorgan-g commented Aug 15, 2025

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Aug 15, 2025

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants