Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite format+analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_benchmarks_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_benchmarks_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build+platform-test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build+platform-test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite local_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite local_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite format+analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite android-build+platform-tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_benchmarks_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite web_benchmarks_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build+platform-test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite ios-build+platform-test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite local_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite local_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers
Copy link
Contributor Author

Manually merging as flutter/flutter#99306 is WIP, and this needs to land today to avoid breaking many PRs

@CaseyHillers CaseyHillers merged commit db5b898 into main Mar 1, 2022
@CaseyHillers CaseyHillers deleted the CaseyHillers-patch-1 branch March 1, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants