Mark FlutterIOOverrides as final
#9719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for marking `IOOverrides` as `base`. Related to dart-lang/sdk#56468
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
bkonyi
changed the title
finalFlutterIOOverrides as final
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request marks the FlutterIOOverrides class as final. This is a good practice that aligns with modern Dart standards, preventing the class from being extended, implemented, or mixed in outside of its library. This change improves code robustness and maintainability, especially in preparation for the upstream IOOverrides class being marked as base. The change is correct and I have no further suggestions.
Contributor
Author
|
This is needed to unblock the failing analyze check on the SDK change: https://dart-review.googlesource.com/c/sdk/+/389520 |
Collaborator
|
test-exempt: unblocks a compilation failure |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 1, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 1, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@db6988d...f0645d8 2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final` (flutter/packages#9719) 2025-07-31 [email protected] [in_app_purchase_storekit] Updated comment (flutter/packages#9445) 2025-07-31 [email protected] [video_player] Separate event stream from player on iOS (flutter/packages#9700) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for marking
IOOverridesasbase.Related to dart-lang/sdk#56468