Extending Timeout on Linux_android android_build_all_packages *
#9717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request increases the timeout for the Linux_android android_build_all_packages stable CI job from 30 to 60 minutes. While the change itself is straightforward, the pull request lacks a description explaining the necessity of this increase. I've added a comment requesting that the author provide this context and link to the relevant issue, as required by the repository's contribution guidelines.
| - name: Linux_android android_build_all_packages stable | ||
| recipe: packages/packages | ||
| timeout: 30 | ||
| timeout: 60 |
There was a problem hiding this comment.
While increasing the timeout might be necessary to fix a flaky build, the pull request description is currently empty. This makes it difficult to understand the reason for this change.
Could you please update the PR description to explain why this timeout increase is needed and link to the issue that this change resolves? This is required by the repository's contribution guidelines1 and is crucial for future maintenance and understanding the history of the CI configuration.
Style Guide References
Footnotes
stuartmorgan-g
approved these changes
Aug 1, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM! I hadn't noticed that the successful builds were so close to the timeout limit, so I assumed the flaky timeout was a flaky hang of some kind. Good find!
stuartmorgan-g
changed the title
Linux_android android_build_all_packages stableLinux_android android_build_all_packages *
Collaborator
|
I've updated this to include the |
stuartmorgan-g
added
the
autosubmit
reidbaker
approved these changes
Aug 1, 2025
Contributor
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
if @stuartmorgan-g is ok with it then I am, that said I might have bumped to 45m instead of doubling the time it takes to build.
auto-submit
bot
removed
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/9717, because - The status or check suite Linux_android android_build_all_packages stable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Collaborator
|
We have quite a few tasks with 60-minute timeouts. I'd rather we deal with tasks that are getting too slow in audits (which I do from time to time in this repo) rather than having them show up as flake that hits all contributors. |
Collaborator
Ha. Timed out because .ci.yaml changes only take effect post-submit. |
stuartmorgan-g
added
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/packages/9717, because - The status or check suite Linux_android_legacy android_platform_tests_legacy_api_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@f0645d8...1a72287 2025-08-01 [email protected] Add an initial AGENTS.md (flutter/packages#9716) 2025-08-01 [email protected] Roll Flutter from c3279ca to 871849e (56 revisions) (flutter/packages#9728) 2025-08-01 [email protected] [webview_flutter_platform_interface] Provide flexible API for loading local HTML files (flutter/packages#9697) 2025-08-01 [email protected] Extending Timeout on `Linux_android android_build_all_packages *` (flutter/packages#9717) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending timeout on
Linux_android android_build_all_packagesto prevent further timeouts to improve dev velocity. This is a temporary solution.Partially Addresses flutter/flutter#173066
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3