[tool] Remove web drive hot reload workaround #9704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See dart-lang/sdk#60289 See flutter/flutter#170612 Add charset to some index.html files which is needed in the new DDC module system.
nshahan
requested review from
LouiseHsu,
bparrishMines,
cbracken and
ditman
as code owners
nshahan
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes the --no-web-experimental-hot-reload workaround from the drive-examples command and its associated tests, aligning with the goal of removing the no-longer-needed workaround. The addition of the <meta charset="UTF-8" /> tag to various index.html files is also a good improvement for web compatibility.
I've identified a minor formatting issue in three of the index.html files where the new line includes trailing whitespace. I've left suggestions to remove it for consistency and code cleanliness.
packages/webview_flutter/webview_flutter/example/assets/www/index.html
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_android/example/assets/www/index.html
Outdated
Show resolved
Hide resolved
packages/webview_flutter/webview_flutter_wkwebview/example/assets/www/index.html
Outdated
Show resolved
Hide resolved
stuartmorgan-g
added
the
override: no changelog needed
Collaborator
|
CHANGELOG override: the minor example app config change is not client-relevant. |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter drive for web should no longer need this workaround.
See dart-lang/sdk#60289
See flutter/flutter#170612
Add charset to some index.html files which is needed in the new DDC module system.