Fixed Camera Switching Bug #9671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively fixes the camera switching bug by introducing a more robust selection mechanism using CameraInfo. The changes are well-distributed across the Dart and native Android code. I've provided a few suggestions to improve code clarity, maintainability, and test correctness. Once these are addressed, this PR should be in great shape.
...era_android_camerax/android/src/test/java/io/flutter/plugins/camerax/CameraSelectorTest.java
Show resolved
Hide resolved
...android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraSelectorProxyApi.java
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/test/android_camera_camerax_test.dart
Show resolved
Hide resolved
camsim99
reviewed
Jul 28, 2025
Contributor
camsim99
left a comment
camsim99
left a comment
There was a problem hiding this comment.
Overall looks good! Left some comments.
...android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraSelectorProxyApi.java
Outdated
Show resolved
Hide resolved
...android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraSelectorProxyApi.java
Outdated
Show resolved
Hide resolved
...android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraSelectorProxyApi.java
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
| case null: | ||
| } | ||
|
|
||
| if (cameraInfo != null) { |
Contributor
There was a problem hiding this comment.
I think to make sure this tests does what we want, we need to check if cameraInfo is the CameraInfo that maps to cameraDescriptions[0], so we need a tighter check here. Please correct me if I'm wrong though!
Contributor
Author
There was a problem hiding this comment.
done. Also, I did sort of a "transitive verification." I can't access the CameraInfo that maps to cameraDescriptions[0] directly in the conditional stub check due to timing issues, so I directly check that cameraInfo is mockBackCameraInfoOne. I verify that mockBackCameraInfoOne is associated with cameraDescriptions[0] below.
// Verify the camera name used to create camera is associated with mockBackCameraInfoOne.
expect(
cameraNameToInfos[cameraDescriptions[0].name],
mockBackCameraInfoOne,
);
camsim99
added
the
autosubmit
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Fixed camera switching issue where phones with multiple back cameras could not correctly switch to some other chosen camera. Fixed by specifying a camera via its CameraInfo instead of its direction. Fixes flutter/flutter#164963 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 31, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 31, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@d914120...db6988d 2025-07-31 [email protected] [tool] Remove web drive hot reload workaround (flutter/packages#9704) 2025-07-30 [email protected] Fixed Camera Switching Bug (flutter/packages#9671) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed camera switching issue where phones with multiple back cameras could not correctly switch to some other chosen camera. Fixed by specifying a camera via its CameraInfo instead of its direction.
Fixes flutter/flutter#164963
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3