[camera_avfoundation] Implementation swift migration - part 10 #9664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates captureToFile and getTemporaryFilePath to Swift and updates the dispatch queue handling to use modern Swift APIs. I've provided suggestions to improve the robustness of the new Swift code by avoiding potential runtime issues related to force-indexing and force-casting.
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part10
branch
from
e47c2b5 to
f472203
Compare
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
.../camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/DefaultCamera.swift
Outdated
Show resolved
Hide resolved
...era/camera_avfoundation/ios/camera_avfoundation/Sources/camera_avfoundation/QueueUtils.swift
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part10
branch
from
f472203 to
50f66ca
Compare
hellohuanlin
approved these changes
Jul 25, 2025
Contributor
Author
|
FYI I've added a commit that removes the ObjC implementation of |
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 29, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 29, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 29, 2025
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…er#9664) Migrates camera implementation as part of flutter/flutter#119109 This PR migrates the 7th chunk of `FLTCam` class to Swift: * `captureToFile` * `getTemporaryFilePath` We can also finally switch to Swift interface for dispatch queue specific because all usages are now in Swift. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@6b2e34e...ed235d1 2025-07-29 [email protected] Roll Flutter from cfbaa18 to 46b097a (12 revisions) (flutter/packages#9695) 2025-07-29 [email protected] [camera_avfoundation] Implementation swift migration - part 10 (flutter/packages#9664) 2025-07-29 [email protected] [interactive_media_ads] Adds remaining methods for internal wrapper of the native `AdsRequest` (flutter/packages#9663) 2025-07-28 [email protected] [camera_android_camerax] Delete unused file (flutter/packages#9634) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR migrates the 7th chunk of
FLTCamclass to Swift:captureToFilegetTemporaryFilePathWe can also finally switch to Swift interface for dispatch queue specific because all usages are now in Swift.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3