[google_sign_in] Update to GoogleSignIn-iOS 9 #9655

stuartmorgan-g · 2025-07-21T14:49:04Z

Updates the dependency on the GoogleSignIn iOS SDK to the recently released 9.0. Some specific benefits include:

Allows wiring up the nonce parameter on iOS, which was plumbed most of the way through already since the PR had landed upstream when nonce was added to google_sign_in, but not fully connected since it wasn't released.
Avoids transitive dependency conflicts with plugins that use AppAuth 2.x.

Fixes flutter/flutter#172453 Finishes flutter/flutter#85439 for iOS

Pre-Review Checklist

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

Updates the dependency on the GoogleSignIn iOS SDK to the recently released 9.0. Some specific benefits include: - Allows wiring up the nonce parameter on iOS, which was plumbed most of the way through already since the PR had landed upstream when nonce was added to `google_sign_in`, but not fully connected since it wasn't released. - Avoids transitive dependency conflicts with plugins that use AppAuth 2.x. Fixes flutter/flutter#172453 Finishes flutter/flutter#85439 for iOS

gemini-code-assist

Code Review

This pull request updates the GoogleSignIn-iOS dependency to version 9.0, adding support for the nonce parameter and resolving transitive dependency issues. The changes correctly implement the nonce parameter in the iOS/macOS native code and update the tests accordingly.

packages/google_sign_in/google_sign_in_ios/darwin/Tests/GoogleSignInTests.m

stuartmorgan-g · 2025-07-21T14:51:17Z

packages/google_sign_in/google_sign_in_ios/darwin/google_sign_in_ios.podspec

-  s.dependency 'AppAuth', '>= 1.7.4'
+  # GTMSessionFetcher is a GoogleSignIn transitive dependency, added here as a
+  # direct dependency to ensure a version which defines modules.
  s.dependency 'GTMSessionFetcher', '>= 3.4.0'


GoogleSignIn now depends on AppAuth 2.x, so we don't need to set a version floor for that one any more. The GTMSessionFetcher dependency there is still only 3.3+ though, so we still need this one.

cbracken

…es#9655)

flutter/packages@cb8fef6...9c85e5e 2025-07-21 [email protected] Roll Flutter from 70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658) 2025-07-21 [email protected] [google_sign_in] Update to GoogleSignIn-iOS 9 (flutter/packages#9655) 2025-07-20 [email protected] Roll Flutter from 440713c to 70a3c3c (11 revisions) (flutter/packages#9653) 2025-07-20 [email protected] Have Gemini ignore Flutter version pin (flutter/packages#9647) 2025-07-18 [email protected] Roll Flutter from 9c626d9 to 440713c (19 revisions) (flutter/packages#9646) 2025-07-18 [email protected] [camera_avfoundation] Implementation swift migration - part 8 (flutter/packages#9635) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#9609) 2025-07-17 [email protected] [two_dimensional_scrollables] Fix missing leading cache extent for TableView (flutter/packages#9636) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1 in /packages/interactive_media_ads/android (flutter/packages#9623) 2025-07-17 [email protected] [pigeon] Adds overrides for constructors and static members of ProxyApis (flutter/packages#9515) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Updates the dependency on the GoogleSignIn iOS SDK to the recently released 9.0. Some specific benefits include: - Allows wiring up the nonce parameter on iOS, which was plumbed most of the way through already since the PR had landed upstream when nonce was added to `google_sign_in`, but not fully connected since it wasn't released. - Avoids transitive dependency conflicts with plugins that use AppAuth 2.x. Fixes flutter/flutter#172453 Finishes flutter/flutter#85439 for iOS ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

flutter/packages@cb8fef6...9c85e5e 2025-07-21 [email protected] Roll Flutter from 70a3c3c to 70cdc0c (4 revisions) (flutter/packages#9658) 2025-07-21 [email protected] [google_sign_in] Update to GoogleSignIn-iOS 9 (flutter/packages#9655) 2025-07-20 [email protected] Roll Flutter from 440713c to 70a3c3c (11 revisions) (flutter/packages#9653) 2025-07-20 [email protected] Have Gemini ignore Flutter version pin (flutter/packages#9647) 2025-07-18 [email protected] Roll Flutter from 9c626d9 to 440713c (19 revisions) (flutter/packages#9646) 2025-07-18 [email protected] [camera_avfoundation] Implementation swift migration - part 8 (flutter/packages#9635) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#9609) 2025-07-17 [email protected] [two_dimensional_scrollables] Fix missing leading cache extent for TableView (flutter/packages#9636) 2025-07-17 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.android.tools.build:gradle from 8.9.0 to 8.11.1 in /packages/interactive_media_ads/android (flutter/packages#9623) 2025-07-17 [email protected] [pigeon] Adds overrides for constructors and static members of ProxyApis (flutter/packages#9515) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

stuartmorgan-g requested review from LongCatIsLooong and cbracken as code owners July 21, 2025 14:49

github-actions bot added p: google_sign_in platform-ios platform-macos labels Jul 21, 2025

stuartmorgan-g mentioned this pull request Jul 21, 2025

[google_sign_in] Support passing a nonce flutter/flutter#85439

Closed

gemini-code-assist bot reviewed Jul 21, 2025

View reviewed changes

packages/google_sign_in/google_sign_in_ios/darwin/Tests/GoogleSignInTests.m Show resolved Hide resolved

stuartmorgan-g commented Jul 21, 2025

View reviewed changes

Add assertion for Gemini

eaa4044

cbracken approved these changes Jul 21, 2025

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 21, 2025

auto-submit bot merged commit 57cbb96 into flutter:main Jul 21, 2025
78 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2025

57cbb96 [google_sign_in] Update to GoogleSignIn-iOS 9 (flutter/packag…

2fc3179

…es#9655)

engine-flutter-autoroll mentioned this pull request Jul 21, 2025

Roll Packages from cb8fef62993f to 57cbb96e8563 (9 revisions) flutter/flutter#172472

Closed

stuartmorgan-g deleted the sign-in-ios-9 branch July 21, 2025 17:02

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 21, 2025

57cbb96 [google_sign_in] Update to GoogleSignIn-iOS 9 (flutter/packag…

34f180e

…es#9655)

engine-flutter-autoroll mentioned this pull request Jul 21, 2025

Roll Packages from cb8fef62993f to 9c85e5e72e7b (10 revisions) flutter/flutter#172479

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[google_sign_in] Update to GoogleSignIn-iOS 9 #9655

[google_sign_in] Update to GoogleSignIn-iOS 9 #9655

Uh oh!

stuartmorgan-g commented Jul 21, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

stuartmorgan-g Jul 21, 2025

Uh oh!

cbracken left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[google_sign_in] Update to GoogleSignIn-iOS 9 #9655

[google_sign_in] Update to GoogleSignIn-iOS 9 #9655

Uh oh!

Conversation

stuartmorgan-g commented Jul 21, 2025

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stuartmorgan-g Jul 21, 2025

Choose a reason for hiding this comment

Uh oh!

cbracken left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants