Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates the extension to work with the newly released google_sign_in 7.x, which reworked the API surface.

The extension method can no longer do as many of the steps, so its utility is lower. Longer term this may not be worth maintaining as a package, but for now this will simplify migration to google_sign_in 7.x for existing clients of this package.

Fixes flutter/flutter#171048

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Updates the extension to work with the newly released `google_sign_in`
7.x, which reworked the API surface.

The extension method can no longer do as many of the steps, so its
utility is lower. Longer term this may not be worth maintaining as a
package, but for now this will simplify migration to `google_sign_in`
7.x for existing clients of this package.

Fixes flutter/flutter#171048
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2025
@auto-submit auto-submit bot merged commit ae64c4e into flutter:main Jun 26, 2025
78 checks passed
@stuartmorgan-g stuartmorgan-g deleted the google-sign-in-extension-update branch June 26, 2025 15:28
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 27, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 27, 2025
flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (flutter#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(flutter#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…n 7 (flutter#9484)

Updates the extension to work with the newly released `google_sign_in` 7.x, which reworked the API surface.

The extension method can no longer do as many of the steps, so its utility is lower. Longer term this may not be worth maintaining as a package, but for now this will simplify migration to `google_sign_in` 7.x for existing clients of this package.

Fixes flutter/flutter#171048

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
flutter/packages@2c8d2bc...4841ada

2025-06-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Check macOS 15 for Xcode analyzer warnings (flutter#9427)"
(flutter/packages#9509)
2025-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list
(flutter#9429)" (flutter/packages#9507)
2025-06-26 [email protected] [ci] Check macOS 15 for Xcode analyzer
warnings (flutter/packages#9427)
2025-06-26 [email protected] [ci] Remove in_app_purchase_storekit from
Xcode analyzer exclusion list (flutter/packages#9429)
2025-06-26 [email protected] [google_sign_in] Add contributor
setup instructions (flutter/packages#9489)
2025-06-26 [email protected] [google_sign_in] Use an activity for
credential requests (flutter/packages#9497)
2025-06-26 [email protected] Roll Flutter from
d733bea to 2773c0c (42 revisions) (flutter/packages#9495)
2025-06-26 [email protected]
[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 7
(flutter/packages#9484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: extension_google_sign_in_as_googleapis_auth triage-web Should be looked at in web triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[extension_google_sign_in_as_googleapis_auth] Update to google_sign_in 3.0.0

2 participants