Skip to content

[in_app_purchase_storekit] Updated comment #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 31, 2025
Merged

[in_app_purchase_storekit] Updated comment #9445

auto-submit merged 1 commit into from
Jul 31, 2025

Conversation

@avni-prajapati
Copy link
Contributor

@avni-prajapati avni-prajapati commented Jun 18, 2025 •
edited by tirth-patel-nc
Loading

Updated the comment refer to StoreKit instead of Android, in example/lib/main.dart

Before

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the Android plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();

After

void main() {
  WidgetsFlutterBinding.ensureInitialized();
  // When using the StoreKit plugin directly it is mandatory to register
  // the plugin as default instance as part of initializing the app.
  InAppPurchaseStoreKitPlatform.registerPlatform();

Issue

Closes flutter/flutter#159623

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Jun 24, 2025
LongCatIsLooong
LongCatIsLooong approved these changes Jul 10, 2025
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, thanks for the fix!

@stuartmorgan-g
Copy link
Collaborator

stuartmorgan-g commented Jul 29, 2025

From triage: @LouiseHsu This still needs a secondary review to land.

vashworth
vashworth approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2025
@auto-submit auto-submit bot merged commit b2aef15 into flutter:main Jul 31, 2025
78 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 1, 2025
@engine-flutter-autoroll
b2aef15 [in_app_purchase_storekit] Updated comment (flutter/packages#…
b519cee 
…9445)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 1, 2025
Merged
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Aug 1, 2025
@engine-flutter-autoroll
Roll Packages from db6988d to f0645d8 (3 revisions) (#173111)
e1f8458 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 6, 2025
@engine-flutter-autoroll @SydneyBao
Roll Packages from db6988d to f0645d8 (3 revisions) (flutter#173111)
6b2cc9e 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
@engine-flutter-autoroll @ksokolovskyi
Roll Packages from db6988d to f0645d8 (3 revisions) (flutter#173111)
8d9fb2a 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
@engine-flutter-autoroll @mboetger
Roll Packages from db6988d to f0645d8 (3 revisions) (flutter#173111)
e77359d 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
@engine-flutter-autoroll @korca0220
Roll Packages from db6988d to f0645d8 (3 revisions) (flutter#173111)
800991d 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli pushed a commit to lucaantonelli/flutter that referenced this pull request Nov 21, 2025
@engine-flutter-autoroll @lucaantonelli
Roll Packages from db6988d to f0645d8 (3 revisions) (flutter#173111)
91567b7 
flutter/packages@db6988d...f0645d8

2025-08-01 [email protected] Mark `FlutterIOOverrides` as `final`
(flutter/packages#9719)
2025-07-31 [email protected]
[in_app_purchase_storekit] Updated comment (flutter/packages#9445)
2025-07-31 [email protected] [video_player] Separate event stream
from player on iOS (flutter/packages#9700)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vashworth vashworth vashworth approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu LouiseHsu is a code owner

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: in_app_purchase platform-ios platform-macos triage-ios Should be looked at in iOS triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[in_app_purchase_storekit] Comment in example/lib/main.dart may be incorrect.

4 participants

@avni-prajapati @stuartmorgan-g @vashworth @LongCatIsLooong