Skip to content

[ci] Increase deprecation check minimum to iOS 17 - #9431

Closed
jmagman wants to merge 2 commits into
flutter:mainfrom
jmagman:ios-deprecation-check
Closed

jmagman wants to merge 2 commits into
flutter:mainfrom
jmagman:ios-deprecation-check

Conversation

@jmagman

@jmagman jmagman commented Jun 13, 2025 •

Copy link
Copy Markdown
Member

I tried this in #7542 and abandoned it because of the integration_test deprecation. That should no longer occur after flutter/flutter#173251.

Exclude camera until flutter/flutter#170438 is completed.
Exclude in_app_purchase_storekit until flutter/flutter#105490 is completed.

There are more iOS 18 deprecation warnings to dig through, so let's get up to 17 and go from there.

Last bump at #7431

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3

@jmagman

jmagman commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Hitting flutter/flutter#170438

@jmagman
jmagman force-pushed the ios-deprecation-check branch from 32b65d5 to 79b5b4f Compare June 26, 2025 17:21
@jmagman

jmagman commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Hitting flutter/flutter#105490

@jmagman
jmagman force-pushed the ios-deprecation-check branch from 861ad54 to d8514ae Compare September 16, 2025 05:40
@lucasjinreal

Copy link
Copy Markdown

clang: error: conflicting deployment targets, both '26.0' and '25.0' are present in environment

@Piinks

Piinks commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Greetings from stale PR triage! 👋
Is this change still on your radar?

@jmagman

jmagman commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

Closing until we get the blockers fixed.

@jmagman

jmagman commented Jan 21, 2026

Copy link
Copy Markdown
Member Author

Hitting flutter/flutter#181291

auto-submit Bot pushed a commit that referenced this pull request Oct 14, 2026
…'videoRotationAngle' on iOS 17+ (#13247)

Remove deprecated AVFoundation camera APIs, replace with iOS 17+ API `videoRotationAngle`. This will allow us to check for deprecations higher than iOS 17 in CI, like #9431.

Migrate CameraSetDeviceOrientationTests to Swift Testing while we're at it to take advantage of parameterization.

I tested this manually and orientation worked as expected. I would upload a video but it seems camera capture doesn't work when connected through a DeviceHub session (presumably a privacy protection) and QuickTime stopped the recording whenever there was an orientation change, so you'll have to trust me it worked manually.

Fixes flutter/flutter#170438

## Pre-Review Checklist

**Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants