Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Rolls Flutter master pin to 7e30df2225f65141e0227e424986311b79d39505

flutter/flutter@8b22f67...7e30df2

@stuartmorgan-g
Copy link
Collaborator Author

It looks like all web integration test shards are hanging on the first test, so something is very broken in this range.

@stuartmorgan-g
Copy link
Collaborator Author

This is almost certainly flutter/flutter#169174:

This change avoids enabling hot reload in the flutter drive tests since they rely on
-d web-server which has known startup issues. When dart-lang/sdk#60289 is
resolved it should be safe to enable hot reload by default for the flutter drive
tests.

Comment on lines 146 to 147
if (platform.environment['CHANNEL']?.toLowerCase() == 'master')
'--no-web-experimental-hot-reload',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the if?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, is this to omit the flag when running against stable? Did the flag not make it into stable yet?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed it was recent (like the breakage) and hadn't, but I just checked the source and it looks like it's in 3.32. I'll remove the if.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025
@auto-submit auto-submit bot merged commit f1636db into flutter:main Jun 10, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jun 11, 2025
flutter/packages@974f152...0b322a2

2025-06-11 [email protected] Roll Flutter master to 2d9977c
(flutter/packages#9402)
2025-06-11 [email protected] [google_maps_flutter] Fix iOS
analysis for newer Xcode (flutter/packages#9415)
2025-06-10 [email protected] [in_app_purchase] Return
jwsRepresentation and jsonRepresentation for StoreKit2
(flutter/packages#9280)
2025-06-10 [email protected] Roll Flutter master to 7e30df2
(flutter/packages#9413)
2025-06-10 [email protected] [vector_graphics]Add
Null Check for Image Retrieval in listener.dart's onDrawImage Function
(flutter/packages#9211)
2025-06-10 [email protected] Roll Flutter master to 8b22f67
(flutter/packages#9407)
2025-06-06 [email protected] Roll Flutter master to d8baa77
(flutter/packages#9379)
2025-06-06 [email protected] Fix the `zIndex`-related issue in the
`copyWith` method. (flutter/packages#9396)
2025-06-06 [email protected] [multi] Remove @tool from docs that
does not work (flutter/packages#9394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
Rolls Flutter master pin to 7e30df2225f65141e0227e424986311b79d39505

flutter/flutter@8b22f67...7e30df2
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
flutter/packages@974f152...0b322a2

2025-06-11 [email protected] Roll Flutter master to 2d9977c
(flutter/packages#9402)
2025-06-11 [email protected] [google_maps_flutter] Fix iOS
analysis for newer Xcode (flutter/packages#9415)
2025-06-10 [email protected] [in_app_purchase] Return
jwsRepresentation and jsonRepresentation for StoreKit2
(flutter/packages#9280)
2025-06-10 [email protected] Roll Flutter master to 7e30df2
(flutter/packages#9413)
2025-06-10 [email protected] [vector_graphics]Add
Null Check for Image Retrieval in listener.dart's onDrawImage Function
(flutter/packages#9211)
2025-06-10 [email protected] Roll Flutter master to 8b22f67
(flutter/packages#9407)
2025-06-06 [email protected] Roll Flutter master to d8baa77
(flutter/packages#9379)
2025-06-06 [email protected] Fix the `zIndex`-related issue in the
`copyWith` method. (flutter/packages#9396)
2025-06-06 [email protected] [multi] Remove @tool from docs that
does not work (flutter/packages#9394)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants