[go_router] add initial json support #110781 #9404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
NearTox
changed the title
Contributor
|
Hi @NearTox thanks for contributing! Would you mind adding tests to verify the change and address the failing checks? |
Contributor
Author
Contributor
|
@NearTox Can you take a look at the failing checks? |
Contributor
Author
|
No yet, I didn't added any test so far. |
Contributor
|
@NearTox Looks like you have some conflicts now. |
11 tasks
NearTox
force-pushed
the
go_router
branch
2 times, most recently
from
2b5a7bf to
16c8142
Compare
|
@chunhtai |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 5, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 5, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support #110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
lucaantonelli
pushed a commit
to lucaantonelli/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@1a72287...83ae18a 2025-08-04 [email protected] [go_router] add initial json support flutter#110781 (flutter/packages#9404) 2025-08-04 [email protected] Update CODEOWNERS (flutter/packages#9721) 2025-08-04 [email protected] [google_maps_flutter_ios] Fix kCGImageAlphaPremultipliedLast implicit conversion from enumeration type (flutter/packages#9720) 2025-08-04 [email protected] Roll Flutter from 871849e to beda687 (34 revisions) (flutter/packages#9745) 2025-08-04 [email protected] [interactive_media_ads] Fixes setting adsresponse on Android (flutter/packages#9744) 2025-08-04 [email protected] [interactive_media_ads]: Adds additional methods to configure ad requests (flutter/packages#9696) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial json support for use in go_router_builder
Adds annotation that enable custom string encoder/decoder, its enable conversion for base64
This allow custom type conversion for parameters, like mentionated in #117261 and #110781
this PR must made before #117261
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is [exempt from CHANGELOG changes].///).If you need help, consider asking for advice on the #hackers-new channel on Discord.