Fix the zIndex-related issue in the copyWith method.
#9396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Jun 6, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing this so quickly!
- I read and followed the relevant style guides and ran the auto-formatter.
The format does not match the autoformatter as run on CI.
packages/google_maps_flutter/google_maps_flutter_platform_interface/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/marker.dart
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/test/types/marker_test.dart
Show resolved
Hide resolved
yiiim
force-pushed
the
fix_google_map_zindex_copywith
branch
from
7ec5d47 to
31198b7
Compare
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 10, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 11, 2025
flutter/packages@974f152...0b322a2 2025-06-11 [email protected] Roll Flutter master to 2d9977c (flutter/packages#9402) 2025-06-11 [email protected] [google_maps_flutter] Fix iOS analysis for newer Xcode (flutter/packages#9415) 2025-06-10 [email protected] [in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 (flutter/packages#9280) 2025-06-10 [email protected] Roll Flutter master to 7e30df2 (flutter/packages#9413) 2025-06-10 [email protected] [vector_graphics]Add Null Check for Image Retrieval in listener.dart's onDrawImage Function (flutter/packages#9211) 2025-06-10 [email protected] Roll Flutter master to 8b22f67 (flutter/packages#9407) 2025-06-06 [email protected] Roll Flutter master to d8baa77 (flutter/packages#9379) 2025-06-06 [email protected] Fix the `zIndex`-related issue in the `copyWith` method. (flutter/packages#9396) 2025-06-06 [email protected] [multi] Remove @tool from docs that does not work (flutter/packages#9394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
This assertion fails when using the `copyWith` method. https://github.com/flutter/packages/blob/007e2f1e468b8e870544c16ce21ad39f97299241/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/marker.dart#L165 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@974f152...0b322a2 2025-06-11 [email protected] Roll Flutter master to 2d9977c (flutter/packages#9402) 2025-06-11 [email protected] [google_maps_flutter] Fix iOS analysis for newer Xcode (flutter/packages#9415) 2025-06-10 [email protected] [in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 (flutter/packages#9280) 2025-06-10 [email protected] Roll Flutter master to 7e30df2 (flutter/packages#9413) 2025-06-10 [email protected] [vector_graphics]Add Null Check for Image Retrieval in listener.dart's onDrawImage Function (flutter/packages#9211) 2025-06-10 [email protected] Roll Flutter master to 8b22f67 (flutter/packages#9407) 2025-06-06 [email protected] Roll Flutter master to d8baa77 (flutter/packages#9379) 2025-06-06 [email protected] Fix the `zIndex`-related issue in the `copyWith` method. (flutter/packages#9396) 2025-06-06 [email protected] [multi] Remove @tool from docs that does not work (flutter/packages#9394) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assertion fails when using the
copyWithmethod.packages/packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/marker.dart
Line 165 in 007e2f1
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3