[in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 #9280

shaunpanjabi · 2025-05-18T18:16:28Z

Providing access to jwsRepresentation. property of the transaction. With the most recent update PurchaseVerificationData returns empty now. I think it could make sense to repurpose it and return the:

jsonRepresentation for localVerificationData
jwsRepresentation for serverVerificationData

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

flutter-dashboard · 2025-05-18T18:16:31Z

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

maks-epowar · 2025-05-23T09:58:25Z

Hi is there any update on adding this? This is more logical than returning empty verification data

LouiseHsu

Approved, with a comment about the versioning

LouiseHsu · 2025-06-02T21:41:30Z

packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

 * Updates minimum supported SDK version to Flutter 3.27/Dart 3.6.
+* Add `jwsRepresentation` to `SK2PurchaseDetails` as `serverVerificationData`
+* Add `jsonRepresentation` to `SK2PurchaseDetails` as `localVerificationData`



The reason the repo_check is failing is b/c of this - could you add lines 3-5 to a new 0.4.1 version and remove the NEXT?

Thanks! I updated to 0.4.2 since 0.4.1 just got merged in recently. Hope that is okay 🙏

auto-submit · 2025-06-03T23:19:37Z

autosubmit label was removed for flutter/packages/9280, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

LouiseHsu · 2025-06-03T23:27:23Z

@LongCatIsLooong Can you take a look at this when you have time? 😺

LongCatIsLooong

Thanks for the patch!

I couldn't find the relevant information in the PurchaseVerificationData documentation so could you clarify how localVerificationData and serverVerificationData are supposed to be used? From reading the storekit documentation, my impression is that you don't have to do anything with localVerificationData (as StoreKit has already verified it), but you can optionally check the signed information in serverVerificationData on your own server or on the device, to verify the purchase?

LongCatIsLooong · 2025-06-04T16:57:55Z

.../in_app_purchase/in_app_purchase_storekit/test/in_app_purchase_storekit_2_platform_test.dart

+      final Stream<List<PurchaseDetails>> stream =
+          iapStoreKitPlatform.purchaseStream;
+
+      late StreamSubscription<List<PurchaseDetails>> subscription;


nit: final instead of late?

I believe it has to be late since it is being referenced inside the listen callback. So it is being referenced before it is initialized.

Ah I didn't notice that. Could you make it late final then, since it looks like subscription isn't getting re-assigned later?

Sure, just updated ✅

LongCatIsLooong · 2025-06-04T17:05:17Z

...hase_storekit/Sources/in_app_purchase_storekit/StoreKit2/InAppPurchasePlugin+StoreKit2.swift

          case .verified(let transaction):
-            self.sendTransactionUpdate(transaction: transaction)
+            self.sendTransactionUpdate(
+              transaction: transaction, receipt: "\(verification.jwsRepresentation)")


(here and below) I don't think the string interpolation here is necessary, since jwsRepresentation is a string itself: https://developer.apple.com/documentation/storekit/verificationresult/jwsrepresentation-21vgo (if I'm looking at the right jwsRepresentation, that is)

LongCatIsLooong · 2025-06-04T17:16:33Z

packages/in_app_purchase/in_app_purchase_storekit/CHANGELOG.md

+## 0.4.2
+
+* Add `jwsRepresentation` to `SK2PurchaseDetails` as `serverVerificationData`
+* Add `jsonRepresentation` to `SK2PurchaseDetails` as `localVerificationData`


Could you add a bit color to what are jwsRepresentation and jsonRepresentation? Also maybe which jwsRepresentation and jsonRepresentation since there are several fields with identical names in the StoreKit documentation. The 2 lines seem a bit vague without the context.

shaunpanjabi · 2025-06-06T03:04:55Z

Thanks for the patch!

I couldn't find the relevant information in the PurchaseVerificationData documentation so could you clarify how localVerificationData and serverVerificationData are supposed to be used? From reading the storekit documentation, my impression is that you don't have to do anything with localVerificationData (as StoreKit has already verified it), but you can optionally check the signed information in serverVerificationData on your own server or on the device, to verify the purchase?

Yeah the localVerificationData isn't really necessary. I just thought it might be useful for debugging locally or for accessing the properties of transaction directly if they aren't already exposed. I'd be open to removing it if people don't think it's useful.

serverVerificationData is used to pass the signed transaction securely to your server so it can be verified.

…tion for StoreKit2 (flutter/packages#9280)

@tool

… StoreKit2 (flutter#9280) Fix for flutter/flutter#164433 Providing access to `jwsRepresentation`. property of the transaction. With the most recent update `PurchaseVerificationData` returns empty now. I think it could make sense to repurpose it and return the: - `jsonRepresentation` for `localVerificationData` - `jwsRepresentation` for `serverVerificationData` ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

@tool

shaunpanjabi added 4 commits May 18, 2025 09:49

add jsonRepresentation to SK2PurchaseDetails

8c340b0

repurpose purchase verification data

d942b58

cleanup

7224cc7

update changelog

a339ec7

shaunpanjabi requested review from LongCatIsLooong and LouiseHsu as code owners May 18, 2025 18:16

github-actions bot added p: in_app_purchase platform-ios platform-macos labels May 18, 2025

shaunpanjabi added 2 commits May 18, 2025 11:28

add test

a9a2c5e

add missing receipt data

4ab2f23

Merge branch 'main' into purchase-details-jsonRepresentation

ada38e4

LouiseHsu approved these changes Jun 2, 2025

View reviewed changes

shaunpanjabi added 6 commits June 2, 2025 16:46

Merge branch 'flutter:main' into purchase-details-jsonRepresentation

5f065b5

add 0.4.1 version

f747fda

Merge branch 'main' into purchase-details-jsonRepresentation

3468ecc

merge test group

b6bd713

version 0.4.2

7e9261b

bump pubspec

2a1d2a5

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 3, 2025

LongCatIsLooong reviewed Jun 4, 2025

View reviewed changes

LongCatIsLooong mentioned this pull request Jun 5, 2025

[in_app_purchase] serverVerificationData is empty on some iOS devices. flutter/flutter#169335

Closed

shaunpanjabi added 2 commits June 5, 2025 20:04

Add more detail to CHANGELOG comment

221861d

Remove unnecessary string interpolation

7e4cae2

shaunpanjabi requested a review from LongCatIsLooong June 7, 2025 01:48

LongCatIsLooong approved these changes Jun 8, 2025

View reviewed changes

shaunpanjabi added 2 commits June 10, 2025 08:45

switch to late final

2d464a8

Merge branch 'flutter:main' into purchase-details-jsonRepresentation

96aa1d4

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2025

auto-submit bot merged commit 3c7859f into flutter:main Jun 10, 2025
80 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025

3c7859f [in_app_purchase] Return jwsRepresentation and jsonRepresenta…

3e4d7c8

…tion for StoreKit2 (flutter/packages#9280)

engine-flutter-autoroll mentioned this pull request Jun 11, 2025

Roll Packages from 974f1522ee03 to 2dad18121449 (8 revisions) flutter/flutter#170441

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025

3c7859f [in_app_purchase] Return jwsRepresentation and jsonRepresenta…

ae46cd9

…tion for StoreKit2 (flutter/packages#9280)

engine-flutter-autoroll mentioned this pull request Jun 11, 2025

Roll Packages from 974f1522ee03 to 0b322a2d9fb5 (9 revisions) flutter/flutter#170443

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 11, 2025

3c7859f [in_app_purchase] Return jwsRepresentation and jsonRepresenta…

4140979

…tion for StoreKit2 (flutter/packages#9280)

engine-flutter-autoroll mentioned this pull request Jun 11, 2025

Roll Packages from 974f1522ee03 to 0b322a2d9fb5 (9 revisions) flutter/flutter#170462

Merged

shaunpanjabi deleted the purchase-details-jsonRepresentation branch June 12, 2025 20:17

tirth-patel-nc mentioned this pull request Jun 19, 2025

[in_app_purchase][iOS] Unable to get VerificationResult value for StoreKit2 flutter/flutter#164433

Closed

[in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 #9280

[in_app_purchase] Return jwsRepresentation and jsonRepresentation for StoreKit2 #9280

Uh oh!

Conversation

shaunpanjabi commented May 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

flutter-dashboard bot commented May 18, 2025

Uh oh!

maks-epowar commented May 23, 2025

Uh oh!

LouiseHsu left a comment

Choose a reason for hiding this comment

Uh oh!

LouiseHsu Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shaunpanjabi Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 3, 2025

Uh oh!

LouiseHsu commented Jun 3, 2025

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

shaunpanjabi Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

shaunpanjabi Jun 10, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

shaunpanjabi commented Jun 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shaunpanjabi commented May 18, 2025 •

edited

Loading

LouiseHsu Jun 2, 2025 •

edited

Loading