[camera_avfoundation] Implementation swift migration - part 3 #9182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
approved these changes
May 6, 2025
packages/camera/camera_avfoundation/example/ios/RunnerTests/CameraTestUtils.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
force-pushed
the
feature/camera-implementation-swift-migration-part3
branch
from
7cf800d to
d9d94d8
Compare
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2025
flutter/packages@e800da7...b2ce3b0 2025-05-07 [email protected] [camera_android] Wait for creating capture session when initializing (flutter/packages#8894) 2025-05-07 [email protected] [various] Delete discontinued packages (flutter/packages#9215) 2025-05-07 [email protected] [camera_avfoundation] Implementation swift migration - part 3 (flutter/packages#9182) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…r#9182) Migrates camera implementation as part of flutter/flutter#119109 This PR prepares for the next big one (`FLTCam` class migration): 1. Extracts a util method for creating a test `FLTCam` instance. After migration, the `FLTCam` constructor is marked with `throws` so it requires some asserts to ignore it in tests 2. Removes dependence on KVO in `StreamingTests` ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…r#9182) Migrates camera implementation as part of flutter/flutter#119109 This PR prepares for the next big one (`FLTCam` class migration): 1. Extracts a util method for creating a test `FLTCam` instance. After migration, the `FLTCam` constructor is marked with `throws` so it requires some asserts to ignore it in tests 2. Removes dependence on KVO in `StreamingTests` ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…r#9182) Migrates camera implementation as part of flutter/flutter#119109 This PR prepares for the next big one (`FLTCam` class migration): 1. Extracts a util method for creating a test `FLTCam` instance. After migration, the `FLTCam` constructor is marked with `throws` so it requires some asserts to ignore it in tests 2. Removes dependence on KVO in `StreamingTests` ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates camera implementation as part of flutter/flutter#119109
This PR prepares for the next big one (
FLTCamclass migration):FLTCaminstance. After migration, theFLTCamconstructor is marked withthrowsso it requires some asserts to ignore it in testsStreamingTestsPre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3