[camerax] Ensure DeviceOrientationManager stops on dispose #9141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 24, 2025
flutter/packages@41211cf...ae4f17d 2025-04-23 [email protected] [camerax] Ensure DeviceOrientationManager stops on dispose (flutter/packages#9141) 2025-04-23 [email protected] [google_maps_flutter_ios] Fix iOS regression where updating a marker hides its info window (flutter/packages#9127) 2025-04-23 [email protected] Redistribute iOS CODEOWNERS (flutter/packages#9129) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
raju-muliyashiya
pushed a commit
to raju-muliyashiya/flutter_packages
that referenced
this pull request
Apr 26, 2025
) This ensures DeviceOrientationManager is released on dispose. Prevents leaked IntentReceiver on close. Fixes: flutter/flutter#166529 ## Pre-Review Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1]. - [X] I updated/added any relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [X] All existing and new tests are passing.
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
) This ensures DeviceOrientationManager is released on dispose. Prevents leaked IntentReceiver on close. Fixes: flutter/flutter#166529 ## Pre-Review Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1]. - [X] I updated/added any relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [X] All existing and new tests are passing.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
) This ensures DeviceOrientationManager is released on dispose. Prevents leaked IntentReceiver on close. Fixes: flutter/flutter#166529 ## Pre-Review Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1]. - [X] I updated/added any relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [X] All existing and new tests are passing.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
) This ensures DeviceOrientationManager is released on dispose. Prevents leaked IntentReceiver on close. Fixes: flutter/flutter#166529 ## Pre-Review Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] page, which explains my responsibilities. - [X] I read and followed the [relevant style guides] and ran [the auto-formatter]. - [X] I signed the [CLA]. - [X] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` - [X] I [linked to at least one issue that this PR fixes] in the description above. - [X] I updated `pubspec.yaml` with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1]. - [X] I updated `CHANGELOG.md` to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1]. - [X] I updated/added any relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1]. - [X] All existing and new tests are passing.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
flutter/packages@41211cf...ae4f17d 2025-04-23 [email protected] [camerax] Ensure DeviceOrientationManager stops on dispose (flutter/packages#9141) 2025-04-23 [email protected] [google_maps_flutter_ios] Fix iOS regression where updating a marker hides its info window (flutter/packages#9127) 2025-04-23 [email protected] Redistribute iOS CODEOWNERS (flutter/packages#9129) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures DeviceOrientationManager is released on dispose. Prevents leaked IntentReceiver on close.
Fixes: flutter/flutter#166529
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).