[rfw] Update tests to no longer depend on a Container pumped via testWidgets.
#9063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Contributor
Author
|
Hi @Hixie, could you please take a look at this PR when you have time? Thanks! |
stuartmorgan-g
requested changes
May 7, 2025
packages/rfw/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.0.32 | |||
|
|
|||
| * Updates tests to no longer depend on a `Container` pumped via `testWidgets`. | |||
Collaborator
There was a problem hiding this comment.
Changes in the test/ directory don't need changelog and version changes, so these should be reverted.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review, I've reverted this change in the latest commit.
Contributor
|
A change that broke this would break tons of other tests across the community. I think we should take this as a sign that the underlying change is too dangerous to make, not as a sign that RFW's tests need changing. |
Collaborator
|
From triage: What's the status here? Is the framework change still something that is going to move forward? |
ksokolovskyi
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 18, 2025
…d via `testWidgets`. (flutter/packages#9063)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 18, 2025
flutter/packages@25d4fa4...715a0a5 2025-06-17 [email protected] [go_router_builder] Update readme to use mixin `with _$RouteName` (flutter/packages#9423) 2025-06-17 [email protected] [rfw] Update tests to no longer depend on a `Container` pumped via `testWidgets`. (flutter/packages#9063) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…estWidgets`. (flutter#9063) This PR updates `rfw` package tests to no longer depend on a `Container` pumped via `testWidgets` to unblock further work on flutter/flutter#163419 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@25d4fa4...715a0a5 2025-06-17 [email protected] [go_router_builder] Update readme to use mixin `with _$RouteName` (flutter/packages#9423) 2025-06-17 [email protected] [rfw] Update tests to no longer depend on a `Container` pumped via `testWidgets`. (flutter/packages#9063) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…estWidgets`. (flutter#9063) This PR updates `rfw` package tests to no longer depend on a `Container` pumped via `testWidgets` to unblock further work on flutter/flutter#163419 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
rfwpackage tests to no longer depend on aContainerpumped viatestWidgetsto unblock further work on flutter/flutter#163419Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3