Skip to content

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Mar 5, 2025

This manual roll should fix the broken rollers and green the tree.

issue filed flutter/flutter#164651 to track this tests failure.

@tarrinneal tarrinneal changed the title manual roll with test change manual roll with video player test disabled Mar 5, 2025
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025
@tarrinneal
Copy link
Contributor Author

The test I disabled is still failing somehow...

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/packages/8803, because - The status or check suite Linux_android android_device_tests_shard_6 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g
Copy link
Collaborator

Try adding a no-op test in the file? It may be that a file with no tests that actually run is considered an error.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/packages/8803, because - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/packages/8803, because - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 6, 2025

autosubmit label was removed for flutter/packages/8803, because - The status or check suite Linux_android android_device_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 6, 2025
@tarrinneal
Copy link
Contributor Author

10,000th times the charm!

@auto-submit auto-submit bot merged commit fc9d5ca into flutter:main Mar 6, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 6, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 6, 2025
flutter/packages@abba683...fc9d5ca

2025-03-06 [email protected] manual roll with video player test
disabled (flutter/packages#8803)
2025-03-05 [email protected] [rfw] Make widget builders
work with loops (flutter/packages#8650)
2025-03-05 [email protected] [shared_preferences_android] dependabot
takeover datastore (flutter/packages#8784)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
This manual roll should fix the broken rollers and green the tree.

issue filed flutter/flutter#164651 to track this tests failure.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
This manual roll should fix the broken rollers and green the tree.

issue filed flutter/flutter#164651 to track this tests failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: video_player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants