[camera_avfoundation] Tests backfilling - part 2 #8796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellohuanlin
reviewed
Mar 5, 2025
...s/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginDelegatingMethodTests.swift
Outdated
Show resolved
Hide resolved
hellohuanlin
reviewed
Mar 5, 2025
...s/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginDelegatingMethodTests.swift
Outdated
Show resolved
Hide resolved
RobertOdrowaz
commented
Mar 6, 2025
...s/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginDelegatingMethodTests.swift
Outdated
Show resolved
Hide resolved
hellohuanlin
approved these changes
Mar 7, 2025
RobertOdrowaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 10, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 10, 2025
flutter/packages@4c5a7ed...464cea5 2025-03-10 [email protected] [camera_avfoundation] Tests backfilling - part 2 (flutter/packages#8796) 2025-03-08 [email protected] [google_sign_in] Add Android account name field as optional (flutter/packages#8573) 2025-03-07 [email protected] Roll Flutter from 321fbc0 to 6b93cf9 (18 revisions) (flutter/packages#8817) 2025-03-07 [email protected] Roll Flutter (stable) from 68415ad to 09de023 (1139 revisions) (flutter/packages#8813) 2025-03-07 [email protected] [google_maps_flutter_web] set icon anchor for markers (flutter/packages#8077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Backfills tests for the CameraPlugin class as part of flutter/flutter#119109 This PR adds tests for methods of `CameraPlugin` that only delegate to a `FLTCam` instance without any (or almost any for `startVideoRecording`) logic. In most circumstances, I would argue that those methods are so trivial that there is no point in testing them but for a plugin rewrite I believe those tests provide a little bit of value. The tests are also appropriately simple to write.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Backfills tests for the CameraPlugin class as part of flutter/flutter#119109 This PR adds tests for methods of `CameraPlugin` that only delegate to a `FLTCam` instance without any (or almost any for `startVideoRecording`) logic. In most circumstances, I would argue that those methods are so trivial that there is no point in testing them but for a plugin rewrite I believe those tests provide a little bit of value. The tests are also appropriately simple to write.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
flutter/packages@4c5a7ed...464cea5 2025-03-10 [email protected] [camera_avfoundation] Tests backfilling - part 2 (flutter/packages#8796) 2025-03-08 [email protected] [google_sign_in] Add Android account name field as optional (flutter/packages#8573) 2025-03-07 [email protected] Roll Flutter from 321fbc0 to 6b93cf9 (18 revisions) (flutter/packages#8817) 2025-03-07 [email protected] Roll Flutter (stable) from 68415ad to 09de023 (1139 revisions) (flutter/packages#8813) 2025-03-07 [email protected] [google_maps_flutter_web] set icon anchor for markers (flutter/packages#8077) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backfills tests for the CameraPlugin class as part of flutter/flutter#119109
This PR adds tests for methods of
CameraPluginthat only delegate to aFLTCaminstance without any (or almost any forstartVideoRecording) logic. In most circumstances, I would argue that those methods are so trivial that there is no point in testing them but for a plugin rewrite I believe those tests provide a little bit of value. The tests are also appropriately simple to write.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.