[pigeon] Dart Class Equality #8788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Mar 6, 2025
packages/pigeon/example/app/lib/src/event_channel_messages.g.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/example/app/lib/src/event_channel_messages.g.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/example/app/lib/src/event_channel_messages.g.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/example/app/lib/src/event_channel_messages.g.dart
Outdated
Show resolved
Hide resolved
packages/pigeon/example/app/lib/src/event_channel_messages.g.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I didn't quite do what you requested, but I did something. |
stuartmorgan-g
requested changes
Mar 7, 2025
stuartmorgan-g
approved these changes
Mar 19, 2025
| } | ||
|
|
||
| bool _deepEquals(Object? a, Object? b) { | ||
| if (a is List && b is List) { |
Collaborator
There was a problem hiding this comment.
Not a fan of the record+pattern approach, eh? ;)
| bool _deepEquals(Object? a, Object? b) { | ||
| if (a is List && b is List) { | ||
| return a.length == b.length && | ||
| a.indexed |
Collaborator
There was a problem hiding this comment.
Nice, I forgot indexed was a thing.
packages/pigeon/platform_tests/shared_test_plugin_code/lib/integration_tests.dart
Outdated
Show resolved
Hide resolved
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 20, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2025
flutter/packages@dd781d4...cf9b0f2 2025-03-20 [email protected] [pigeon] Dart Class Equality (flutter/packages#8788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 20, 2025
flutter/packages@dd781d4...cf9b0f2 2025-03-20 [email protected] [pigeon] Dart Class Equality (flutter/packages#8788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Adds Equality and Hash methods to custom classes in Dart. I am still working on other languages, but this can be a standalone pr while I complete the others. fixes flutter/flutter#118087
zhangyuang
pushed a commit
to zhangyuang/flutter-fork
that referenced
this pull request
Jun 9, 2025
flutter/packages@dd781d4...cf9b0f2 2025-03-20 [email protected] [pigeon] Dart Class Equality (flutter/packages#8788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Adds Equality and Hash methods to custom classes in Dart. I am still working on other languages, but this can be a standalone pr while I complete the others. fixes flutter/flutter#118087
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
flutter/packages@dd781d4...cf9b0f2 2025-03-20 [email protected] [pigeon] Dart Class Equality (flutter/packages#8788) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Equality and Hash methods to custom classes in Dart.
I am still working on other languages, but this can be a standalone pr while I complete the others.
fixes flutter/flutter#118087