[various] Bump androidx.test:core to 1.4.0 #8710
Conversation
stuartmorgan-g
requested review from
bparrishMines,
camsim99,
gmackall,
matanlurey,
reidbaker and
tarrinneal
as code owners
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
|
||
| dependencies { | ||
| testImplementation 'junit:junit:4.13.2' | ||
| androidTestImplementation 'androidx.test:runner:1.2.0' |
There was a problem hiding this comment.
Deleted because there's a duplicate dependency 4 lines below, but using androidXTestVersion.
|
test-exempt: rolling dependencies |
reidbaker
left a comment
reidbaker
left a comment
There was a problem hiding this comment.
FWIW 1.4 is from 2021 the latest stable is 1.6.1
https://developer.android.com/jetpack/androidx/releases/test#version_140_3
Yes, I picked something conservative since it was part of the roller fix because I didn't want to get into conflict hell or cascading-changes hell. Separate from this, maybe we should consider turning dependabot back on for this package? We are explicitly ignoring it right now, IIRC because the Android team felt that it wasn't valuable enough for the PR churn it caused. This latent issue the flip side of that decision. (/cc @jmagman who I know has been looking at our dependabot configs). |
stuartmorgan-g
added
the
autosubmit
It's only only for major versions, I can swap it to minor as well. packages/.github/dependabot.yml Lines 129 to 130 in c44c228 |
And it wasn't that intentional, I made all the test dependencies ignore minor and patch. Probably wiser to ignore just patches and then lock minor down on a case-by-case basis. |
Correction: it wasn't that intentional by me. |
|
…gnore patch (#8712) #8710 (comment) Default to dependabot to ignore only patch versions for test dependencies and com.android.tools.build:gradle, and update major and minor. We can revert for any that get noisy. The minor/patch ignore has been around awhile: https://github.com/flutter/packages/pull/2832/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28R120-R121
flutter/packages@c44c228...01d3d5c 2025-02-27 [email protected] Manual roll Flutter from 043b719 to 1659206 (19 revisions) (flutter/packages#8728) 2025-02-27 [email protected] Manual roll Flutter from 911aa75 to 043b719 (flutter/packages#8693) 2025-02-26 [email protected] Dependabot to update major and minor versions of test dependencies, ignore patch (flutter/packages#8712) 2025-02-26 [email protected] [local_auth] Update to use flutter.targetSdkVersion (flutter/packages#8695) 2025-02-26 [email protected] [go_router_builder]: Handle invaild params (flutter/packages#8405) 2025-02-26 [email protected] [pigeon] Timestamp test steps in CI (flutter/packages#8716) 2025-02-26 [email protected] [camera_android_camerax] Fix 90°-off preview rotation (flutter/packages#8629) 2025-02-26 [email protected] [go_router] Secured empty matches in canPop (flutter/packages#8557) 2025-02-26 [email protected] [tool] Update targetsdk version to 35 from 32 (flutter/packages#8694) 2025-02-26 [email protected] [various] Bump androidx.test:core to 1.4.0 (flutter/packages#8710) 2025-02-26 [email protected] [camera] Disable flaky tests (flutter/packages#8708) 2025-02-26 [email protected] [url_launcher][web] Prevent browser from navigating when followLink isn't called (flutter/packages#8675) 2025-02-26 [email protected] [various] Remove plugin-level `integration_test` dependencies (flutter/packages#8711) 2025-02-26 [email protected] [ci] Lengthen custom tests timeout (flutter/packages#8715) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This is pulled out of flutter#8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.
…gnore patch (flutter#8712) flutter#8710 (comment) Default to dependabot to ignore only patch versions for test dependencies and com.android.tools.build:gradle, and update major and minor. We can revert for any that get noisy. The minor/patch ignore has been around awhile: https://github.com/flutter/packages/pull/2832/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28R120-R121
This is pulled out of flutter#8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless. This updates all packages in the repo to have `androidx.test:core` 1.4.0 if it's not already higher. This fixes a latent problem where older versions of `androidx.test.core` aren't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency on `integration_test`, which forced a higher version of that package, but `integration_test` will stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-old `androidx.test:core`.
…gnore patch (flutter#8712) flutter#8710 (comment) Default to dependabot to ignore only patch versions for test dependencies and com.android.tools.build:gradle, and update major and minor. We can revert for any that get noisy. The minor/patch ignore has been around awhile: https://github.com/flutter/packages/pull/2832/files#diff-dd4fbda47e51f1e35defb9275a9cd9c212ecde0b870cba89ddaaae65c5f3cd28R120-R121
6 participants
This is pulled out of #8693 to land on its own while the other issues with that PR are investigated, since it's a useful change regardless.
This updates all packages in the repo to have
androidx.test:core1.4.0 if it's not already higher. This fixes a latent problem where older versions ofandroidx.test.corearen't compatible with targeting the current SDK, because it has activities that are not annotated as exported. This issue is currently being masked by the dependency onintegration_test, which forced a higher version of that package, butintegration_testwill stop exporting that dependency onto the app as of recent master, dropping all the packages here back to a too-oldandroidx.test:core.