[pigeon] adds Internal options #8709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
approved these changes
Mar 7, 2025
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with minor comments.
|
Kindly requesting what the status of this PR is? |
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2025
flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
Separates the user facing options from the internal use of options to avoid exposing settings we don't need the users to access. fixes flutter/flutter#161634 Also adds option to prevent merging of pigeon definition file options. fixes flutter/flutter#163159 Also removes injection of overflow members for testing from public facing api surface.
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
Separates the user facing options from the internal use of options to avoid exposing settings we don't need the users to access. fixes flutter/flutter#161634 Also adds option to prevent merging of pigeon definition file options. fixes flutter/flutter#163159 Also removes injection of overflow members for testing from public facing api surface.
romanejaquez
pushed a commit
to romanejaquez/flutter
that referenced
this pull request
Aug 14, 2025
flutter/packages@ff7724c...d450e1b 2025-03-17 [email protected] [image_picker] Fix getMedia on Linux (flutter/packages#8811) 2025-03-17 [email protected] Add a carve-out on the commenting requirement (flutter/packages#8855) 2025-03-17 [email protected] [camera] Fix unit test asserting external value (flutter/packages#8814) 2025-03-17 [email protected] [pigeon] adds Internal options (flutter/packages#8709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the user facing options from the internal use of options to avoid exposing settings we don't need the users to access. fixes flutter/flutter#161634
Also adds option to prevent merging of pigeon definition file options. fixes flutter/flutter#163159
Also removes injection of overflow members for testing from public facing api surface.