[rfw] Make widget builders work with loops #8650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tugorez
force-pushed
the
builder-loops
branch
2 times, most recently
from
2387401 to
c881159
Compare
stuartmorgan-g
changed the title
tugorez
force-pushed
the
builder-loops
branch
from
c881159 to
88c0bc0
Compare
Contributor
Author
|
@Hixie PTAL when you get a chance. It seems I forgot to consider loops when landing the builders implementation |
tugorez
force-pushed
the
builder-loops
branch
from
88c0bc0 to
65e5859
Compare
Member
|
I'm interested in how this review pans out. |
Hixie
approved these changes
Mar 5, 2025
Contributor
Hixie
left a comment
Hixie
left a comment
There was a problem hiding this comment.
Seems fine to me, but I must admit I'm no longer sufficiently familiar with this code to say this with confidence.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 6, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 6, 2025
flutter/packages@abba683...fc9d5ca 2025-03-06 [email protected] manual roll with video player test disabled (flutter/packages#8803) 2025-03-05 [email protected] [rfw] Make widget builders work with loops (flutter/packages#8650) 2025-03-05 [email protected] [shared_preferences_android] dependabot takeover datastore (flutter/packages#8784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
**Make widget builders work with loops** Fixes flutter/flutter#161544
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
**Make widget builders work with loops** Fixes flutter/flutter#161544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make widget builders work with loops
Fixes flutter/flutter#161544
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.