Skip to content

go_router_builder: latest dependencies - #8326

Merged
auto-submit[bot] merged 15 commits into
mainfrom
grb_latest_analyzer
Jan 7, 2025
Merged

auto-submit[bot] merged 15 commits into
mainfrom
grb_latest_analyzer

Conversation

@kevmoo

@kevmoo kevmoo commented Dec 18, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo

kevmoo commented Dec 19, 2024

Copy link
Copy Markdown
Contributor Author

@chunhtai @stuartmorgan – thoughts on Linux analyze_legacy N-1 failing? I think it's testing a too-old version of Flutter. How can I tweak that?

@stuartmorgan-g

Copy link
Copy Markdown
Contributor

thoughts on Linux analyze_legacy N-1 failing? I think it's testing a too-old version of Flutter.

I don't understand what you mean by "too old". N-1 is the previous stable version. That's a version that exists, and that this package's pubspec claims it supports, but that fails to resolve with your changes:

Resolving dependencies...
Because analyzer >=6.9.0 depends on macros >=0.1.3-main.0 <0.1.4 which depends on _macros 0.3.3 from sdk, analyzer >=6.9.0 requires _macros 0.3.3 from sdk.
So, because no versions of _macros from sdk match 0.3.3 and go_router_builder depends on analyzer >=6.9.0 <8.0.0, version solving failed.

How can I tweak that?

Tweak what? You can't change what the N-1 test is testing because the whole point of that test is to find problems like this and prevent publishing them since they would break people.

You can either use min dependency versions that are compatible with the version of Flutter you are claiming support for, or you can change the version you are claiming support for to match the reality of what the dependencies you want will allow.

@kevmoo

kevmoo commented Dec 27, 2024

Copy link
Copy Markdown
Contributor Author

@stuartmorgan – I think I tried to land this before the "current" SDK was bump up. Hopefully this fixes things. Sorry for the confusion.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@auto-submit

auto-submit Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Windows_x64 custom_package_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@auto-submit

auto-submit Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Linux_android android_platform_tests_shard_1 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@auto-submit

auto-submit Bot commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_5 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 2, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2025
@auto-submit

auto-submit Bot commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Mac_arm64 ios_platform_tests_shard_4 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 3, 2025
@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit

auto-submit Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 6, 2025
@auto-submit

auto-submit Bot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/packages/8326, due to - The status or check suite Mac_arm64 macos_platform_tests master - packages has failed. Please fix the issues identified (or deflake) before re-applying this label.

@kevmoo

kevmoo commented Jan 6, 2025 •

Copy link
Copy Markdown
Contributor Author

@stuartmorgan – sorry to bother you. Suggestions for dealing w/ unrelated flakes?
We generally don't land even if we're very confident we didn't cause the failures, right?

@stuartmorgan-g

Copy link
Copy Markdown
Contributor

Correct, we re-run the failing test until it passes. If it's some specific bad flake, we disable that test and file an issue.

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025
@auto-submit
auto-submit Bot merged commit 3fc6b7a into main Jan 7, 2025
@auto-submit
auto-submit Bot deleted the grb_latest_analyzer branch January 7, 2025 17:34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2025
github-merge-queue Bot pushed a commit to flutter/flutter that referenced this pull request Jan 7, 2025
flutter/packages@07ae98c...3fc6b7a

2025-01-07 [email protected] go_router_builder: latest
dependencies (flutter/packages#8326)
2025-01-06 [email protected] [go_router]
Updates readme to reflect current status (flutter/packages#8374)
2025-01-06 [email protected] [in_app_purchase_storekit] fix finish()
not completing (flutter/packages#8324)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants