[shared_preferences] Fix JSON parsing issue with _decodeValue #8211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan-g
requested changes
Dec 3, 2024
packages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart
Outdated
Show resolved
Hide resolved
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
2 times, most recently
from
17b9578 to
daf7473
Compare
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
from
daf7473 to
be1e837
Compare
stuartmorgan-g
approved these changes
Dec 5, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM with minor fixes, assuming @ditman is happy with it.
...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart
Outdated
Show resolved
Hide resolved
...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart
Outdated
Show resolved
Hide resolved
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
4 times, most recently
from
efbb8a4 to
768cdd6
Compare
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
2 times, most recently
from
c544578 to
e291e66
Compare
Contributor
Author
|
@ditman can you please watch this PR when you have time? |
Contributor
Author
|
@ditman hi! Happy new year!:) Can you see the PR, please? |
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
from
e291e66 to
fb2a65b
Compare
Contributor
Author
|
@stuartmorgan Hello! |
Collaborator
I'm not sure what you are asking exactly; I've already reviewed it. What help are you looking for from me? |
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
from
fb2a65b to
3a54a90
Compare
tarrinneal
approved these changes
Feb 14, 2025
Contributor
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
I think this is fine as is. @stuartmorgan if you'd like to merge it without @ditman taking a look, I'm ok with that as well.
This comment was marked as off-topic.
This comment was marked as off-topic.
Collaborator
This is straightforward enough that our reviews are sufficient. |
stuartmorgan-g
added
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2025
flutter/packages@8542af3...cb4fb13 2025-02-18 [email protected] [shared_preferences] Fix JSON parsing issue with _decodeValue (flutter/packages#8211) 2025-02-18 [email protected] [camera_avfoundation] Migrate tests to Swift - part 2 (flutter/packages#8613) 2025-02-18 [email protected] [google_sign_in] Adopt task queues for Android (flutter/packages#8622) 2025-02-17 [email protected] Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) (flutter/packages#8614) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb
pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…r#8211) [shared_preferences] Fix JSON parsing issue with getAllWithParameters this is a restored PR flutter#5813 Fixes flutter/flutter#156574 https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
FMorschel
pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…r#8211) [shared_preferences] Fix JSON parsing issue with getAllWithParameters this is a restored PR flutter#5813 Fixes flutter/flutter#156574 https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR #5813
Fixes flutter/flutter#156574
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests