[webview_flutter] Updates minimum supported webview_flutter_android from 3.16.0 to 4.0.0
#7844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
webview_flutter_android from 3.16.0 to 4.0.0
Contributor
Author
|
This is now waiting on the discussion in #7801 (comment) |
stuartmorgan-g
approved these changes
Oct 10, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM since webview_flutter_android 4.0 was already published, and per discussion in the other issue there's not really a good way to unwind that.
To capture here: the reason this isn't a breaking change, and thus a major version change, is that per https://docs.flutter.dev/reference/supported-platforms 3.24 already only supports 21+, so since this package requires 3.24, the platforms being dropped here already weren't supported by Flutter itself, so nobody should have a build that can be affected by this. (Which is also why flutter_webview_android could have stayed at 3.x)
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2024
…android` from 3.16.0 to 4.0.0 (flutter/packages#7844)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2024
flutter/packages@f1a3da2...67401e1 2024-10-10 [email protected] Roll Flutter from 2d45fb3 to 6790525 (7 revisions) (flutter/packages#7843) 2024-10-10 [email protected] [webview_flutter] Updates minimum supported `webview_flutter_android` from 3.16.0 to 4.0.0 (flutter/packages#7844) 2024-10-10 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.12.0 to 1.12.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7801) 2024-10-10 [email protected] [interactive_media_ads] Fixes bug where Android would show the last frame of the previous Ad before playing the current one (flutter/packages#7835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webview_flutter_androidnow requires API 21+ from #7801. This bumps thewebview_flutter_androidversion and updates the readme in the app-facing package.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.