[google_maps_flutter_android] Update JSON code to Pigeon for BitmapDescriptor, Cap, and PatternItem
#7840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaakovschectman
requested review from
a team,
gmackall,
jokerttu and
stuartmorgan-g
stuartmorgan-g
requested changes
Oct 11, 2024
Collaborator
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Looks good overall, just some small comments. It's great to see all the Dart JSON code going away!
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
...google_maps_flutter_android/android/src/main/java/io/flutter/plugins/googlemaps/Convert.java
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_android/pigeons/messages.dart
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
…`BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
…`BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 14, 2024
…`BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 14, 2024
flutter/packages@67401e1...1e670f2 2024-10-14 [email protected] [image_picker] Update for non-nullable generics in Pigeon (flutter/packages#7775) 2024-10-14 [email protected] [camera_android] Convert calls from native to dart side to Pigeon. (flutter/packages#7857) 2024-10-14 [email protected] [google_maps_flutter_android] Update JSON code to Pigeon for `BitmapDescriptor`, `Cap`, and `PatternItem` (flutter/packages#7840) 2024-10-13 [email protected] [flutter_markdown] Soft wrapping in blockquotes (flutter/packages#7848) 2024-10-12 [email protected] [google_maps_flutter] Update iOS Pigeon for non-nullable generics (flutter/packages#7792) 2024-10-11 [email protected] [pigeon] Swift implementation for ProxyApis (flutter/packages#6602) 2024-10-11 [email protected] [camera_android_camerax] Remove duplicated 'report' in README.md (flutter/packages#7708) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the old untyped implementations with typesafe approaches using the recently updated platform interface.
Parts of flutter/flutter#155122, flutter/flutter#154737, and flutter/flutter#155121
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.