[interactive_media_ads] Fixes bug where Android would show the last frame of the previous Ad before playing the current one #7835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-android
platform-ios
p: interactive_media_ads
bparrishMines
changed the title
Contributor
Author
|
cc @harold1208 |
bparrishMines
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 11, 2024
…e last frame of the previous Ad before playing the current one (flutter/packages#7835)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 11, 2024
flutter/packages@f1a3da2...67401e1 2024-10-10 [email protected] Roll Flutter from 2d45fb3 to 6790525 (7 revisions) (flutter/packages#7843) 2024-10-10 [email protected] [webview_flutter] Updates minimum supported `webview_flutter_android` from 3.16.0 to 4.0.0 (flutter/packages#7844) 2024-10-10 49699333+dependabot[bot]@users.noreply.github.com [webview]: Bump androidx.webkit:webkit from 1.12.0 to 1.12.1 in /packages/webview_flutter/webview_flutter_android/android (flutter/packages#7801) 2024-10-10 [email protected] [interactive_media_ads] Fixes bug where Android would show the last frame of the previous Ad before playing the current one (flutter/packages#7835) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that VideoView continues to show the last frame of the previous video until the new video starts playing. This causes the
VideoViewto momentarily show the last frame while the new video was being prepared. It looks like neithervideoView.setUri(null)orvideoView.stopPlaybackwould reset the state.The simplest solution I could find would be to create a new
VideoViewwhenever an Ad stops playing.Related links:
google/ExoPlayer#1942
https://stackoverflow.com/questions/25660994/clear-video-frame-from-surfaceview-on-video-complete
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.