[video_player] Remove -Werror from Android build #7776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In flutter/plugins#3019 -Werror was incorrectly added directly to the plugin build itself, which impacts client builds. We've since updated our builds to set these flags on the project only when building our own example app, which gives us the CI benefits of this flag without burdening clients with restrictive build settings, so this is no longer needed. Fixes flutter/flutter#148478
Collaborator
Author
|
I checked the whole repo; this is the only package that had this mistake. |
reidbaker
approved these changes
Oct 3, 2024
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 3, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 3, 2024
flutter/packages@7c97c88...429650f 2024-10-03 [email protected] [camera, google_sign_in, espresso] Bump guava to version `33.3.1`. (flutter/packages#7773) 2024-10-03 [email protected] [video_player] Remove -Werror from Android build (flutter/packages#7776) 2024-10-03 [email protected] [pigeon] chore(readme): deprecated command of running pigeon (flutter/packages#7761) 2024-10-02 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.9.1 to 1.9.2 in /packages/image_picker/image_picker_android/android (flutter/packages#7607) 2024-10-02 [email protected] Add percentile computations to benchmark scores (flutter/packages#7760) 2024-10-02 [email protected] [various] Unpin some dev dependencies (flutter/packages#7762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ozyl
added a commit
to ozyl/flutter_packages
that referenced
this pull request
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In flutter/plugins#3019 -Werror was incorrectly added directly to the plugin build itself, which impacts client builds. We've since updated our builds to set these flags on the project only when building our own example app, which gives us the CI benefits of this flag without burdening clients with restrictive build settings, so this is no longer needed.
Fixes flutter/flutter#148478
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.