Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates the version of Pigeon used for url_launcher_android to pick up non-nullable collection support, and updates the Pigeon definition file accordingly.

This has no effect on the native code since Java doesn't enforce generic non-nullability, but it extends the type safety on the Dart side until the Pigeon layer, rather than the Dart plugin code.

Part of flutter/flutter#155891

Pre-launch Checklist

Updates the version of Pigeon used for `url_launcher_android` to pick up
non-nullable collection support, and updates the Pigeon definition file
accordingly.

This has no effect on the native code since Java doesn't enforce generic
non-nullability, but it extends the type safety on the Dart side until
the Pigeon layer, rather than the Dart plugin code.

Part of flutter/flutter#155891
Copy link
Contributor

@tarrinneal tarrinneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick and easy

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 4, 2024
@auto-submit auto-submit bot merged commit 6dd7f6b into flutter:main Oct 4, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Oct 4, 2024
flutter/packages@429650f...05bf1d4

2024-10-04 [email protected] [various] Update Swift plugins for non-nullable generics (flutter/packages#7742)
2024-10-04 [email protected] [url_launcher] Update Android Pigeon (flutter/packages#7744)
2024-10-04 [email protected] [xdg_directories] Add `stateHome` property (flutter/packages#7766)
2024-10-03 [email protected] [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781)
2024-10-03 [email protected] [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: url_launcher platform-android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants