-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[pigeon] update deprecated command in README of the example #7709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running `flutter pub run pigeon --input path/to/input.dart` will output `Deprecated. Use `dart run` instead.` at the start of the output.
|
Good catch! This will need an update to the changelog, I think a |
|
Thank you for reviewing the change, IMO Though I can add it if needed. |
The issue is that README changes don't get published without a new version, I could wrap this change up in another pr I'm making to avoid the issue, or @stuartmorgan could grant an exception for this case. |
|
if they can grant an exception, I would wait. Otherwise, if you prefer to have this change documented in |
|
This README isn't published, because pub.dev prioritizes |
|
CHANGELOG override: minor update to instructions for local running. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tarrinneal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, there ya go! Thanks for putting this together!
flutter/packages@0321757...27c9853 2024-09-28 [email protected] [pigeon] fix int bug (flutter/packages#7725) 2024-09-28 [email protected] [pigeon] update deprecated command in README of the example (flutter/packages#7709) 2024-09-27 [email protected] [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@0321757...27c9853 2024-09-28 [email protected] [pigeon] fix int bug (flutter/packages#7725) 2024-09-28 [email protected] [pigeon] update deprecated command in README of the example (flutter/packages#7709) 2024-09-27 [email protected] [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
*Update outdated command in `README.md` of running [pigeon](https://pub.dev/packages/pigeon).* Same as #7709
Replace a deprecated command in the instructions of using
pigeon.Running
flutter pub run pigeon --input path/to/input.dartwill output the following at the start of the output:Deprecated. Use `dart run` instead.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).