[google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" #7664
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for the contribution!
Which of the linked exemption reasons are you requesting an exemption under? |
Thanks for your feedback! I believe this PR is a small tweak, so I thought it might be exempt from versioning. If that's incorrect, I'd be happy to uncheck the box and make the necessary changes—I'm still learning the process. |
The reasons a PR would be exempt are those listed in the linked document. |
I updated the version inside |
|
@stuartmorgan, can we merge this PR? |
|
@dhiaCodes In order to land, the PR needs passing all CI checks, and then to be reviewed. Please see the Details section of the |
|
@stuartmorgan I get it. Now it has passed all CI checks and is ready for your review. thank you |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks!
@tarrinneal Could you do the secondary approval on this one?
tarrinneal
left a comment
tarrinneal
left a comment
There was a problem hiding this comment.
Thanks for putting this together!
stuartmorgan-g
added
the
autosubmit
flutter/packages@0321757...27c9853 2024-09-28 [email protected] [pigeon] fix int bug (flutter/packages#7725) 2024-09-28 [email protected] [pigeon] update deprecated command in README of the example (flutter/packages#7709) 2024-09-27 [email protected] [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@0321757...27c9853 2024-09-28 [email protected] [pigeon] fix int bug (flutter/packages#7725) 2024-09-28 [email protected] [pigeon] update deprecated command in README of the example (flutter/packages#7709) 2024-09-27 [email protected] [google_maps_flutter] Fix incorrect comment: Change "marker" to "polyline" (flutter/packages#7664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…line" (flutter#7664) *This pull request fixes an incorrect comment in the `polyline.dart` file.* fixes [#155379 ](flutter/flutter#155379)
3 participants
This pull request fixes an incorrect comment in the
polyline.dartfile.fixes #155379
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.