Revert "[webview_flutter] Improve flaky scroll tests" #7652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df88c81.
stuartmorgan-g
requested review from
bparrishMines and
cbracken
as code owners
bparrishMines
approved these changes
Sep 16, 2024
tarrinneal
added
the
emergency
Contributor
|
Landing on red to fix the tree? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 17, 2024
flutter/packages@df88c81...4f2b9cd 2024-09-17 [email protected] Roll Flutter from 5d83a98 to c4c9f47 (15 revisions) (flutter/packages#7656) 2024-09-17 [email protected] Roll Flutter from 2d30fe4 to 5d83a98 (5 revisions) (flutter/packages#7650) 2024-09-17 [email protected] Revert "[webview_flutter] Improve flaky scroll tests" (flutter/packages#7652) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7621
The re-enabled tests are failing in post-submit.
Alternately, instead of reverting we could just re-add the skips with the link, if we still want to keep the updated version as a better foundation to work from.