[go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) #7647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cedvdb
changed the title
cedvdb
commented
Sep 15, 2024
Contributor
Author
There was a problem hiding this comment.
Here we can't predict whether or not loc starts with / or not as it is user defined. We could make it so the GoRoute constructor requires all routes to start with / but that would be a breaking change
cedvdb
changed the title
cedvdb
changed the title
cedvdb
changed the title
cedvdb
changed the title
cedvdb
changed the title
Contributor
Author
|
@Hangyujin requesting the additional necessary review |
hannah-hyj
approved these changes
Oct 3, 2024
Member
hannah-hyj
left a comment
hannah-hyj
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution!
Member
|
Can you update the PR to resolve the conflicts |
Contributor
Author
|
@Hangyujin done, not sure why all previous commits were readded 9 minutes ago, I only rebased since your approval (and added a typo fix for my change in changelog). |
chunhtai
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 4, 2024
…child routes to have the same path forms ) (flutter/packages#7647)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 4, 2024
flutter/packages@429650f...05bf1d4 2024-10-04 [email protected] [various] Update Swift plugins for non-nullable generics (flutter/packages#7742) 2024-10-04 [email protected] [url_launcher] Update Android Pigeon (flutter/packages#7744) 2024-10-04 [email protected] [xdg_directories] Add `stateHome` property (flutter/packages#7766) 2024-10-03 [email protected] [file_selector] Update Android Pigeon for non-nullable generics (flutter/packages#7781) 2024-10-03 [email protected] [go_router] Relax subroute path requirements (allow root and child routes to have the same path forms ) (flutter/packages#7647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
GoRouteconstructor allowed Schroedinger routes which were neither in a valid state nor an invalid state until they were used. EG:GoRoute(path: '/some-route')was valid as a top route but invalid as a child route. This prevents routes from being moved around and prevents building upon go router.To solve this I see two solution:
/(or none)/Since I did not want to introduce a breaking change I followed option 2, which allows all routes to be of the form
/some-routeorsome-route. However, breaking changes aside, I believe it would be better to use solution 1 as it's more predictible.@chunhtai What do you think about those options ?
Related issue: Fix flutter/flutter#145867
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.