Skip to content

[pigeon] Validates support for nested collections with generic types. #7614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 9 commits into from
Sep 19, 2024
Merged

[pigeon] Validates support for nested collections with generic types. #7614

auto-submit merged 9 commits into from
Sep 19, 2024

Conversation

@tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Sep 10, 2024 •
edited
Loading

Validates support for nested collections with generic types.

Really just adds tests to ensure behavior.

small step toward flutter/flutter#116117

@tarrinneal tarrinneal changed the title Custom codecs 7 the nest awakens [pigeon[ Validates support for nested collections with generic types. Sep 18, 2024
@tarrinneal tarrinneal marked this pull request as ready for review September 19, 2024 00:29
@tarrinneal tarrinneal changed the title [pigeon[ Validates support for nested collections with generic types. [pigeon] Validates support for nested collections with generic types. Sep 19, 2024
stuartmorgan-g
stuartmorgan-g approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2024
@auto-submit auto-submit bot merged commit f54fe93 into flutter:main Sep 19, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 20, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2024
@engine-flutter-autoroll
f54fe93 [pigeon] Validates support for nested collections with generi…
20ae284 
…c types. (flutter/packages#7614)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 20, 2024
@engine-flutter-autoroll
Roll Packages from d83d021 to f54fe93 (1 revision) (#155459)
609b603 
flutter/packages@d83d021...f54fe93

2024-09-19 [email protected] [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Packages from d83d021 to f54fe93 (1 revision) (flutter#155459)
d9ebdf4 
flutter/packages@d83d021...f54fe93

2024-09-19 [email protected] [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 26, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Packages from d83d021 to f54fe93 (1 revision) (flutter#155459)
ad8640e 
flutter/packages@d83d021...f54fe93

2024-09-19 [email protected] [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Packages from d83d021 to f54fe93 (1 revision) (flutter#155459)
8e03e52 
flutter/packages@d83d021...f54fe93

2024-09-19 [email protected] [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel pushed a commit to thejitenpatel/flutter that referenced this pull request Sep 27, 2024
@engine-flutter-autoroll @thejitenpatel
Roll Packages from d83d021 to f54fe93 (1 revision) (flutter#155459)
488fa34 
flutter/packages@d83d021...f54fe93

2024-09-19 [email protected] [pigeon] Validates support for nested collections with generic types. (flutter/packages#7614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@hellohuanlin hellohuanlin Awaiting requested review from hellohuanlin

@LouiseHsu LouiseHsu Awaiting requested review from LouiseHsu

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: pigeon platform-android platform-ios platform-linux platform-macos platform-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal @stuartmorgan-g