Skip to content

Conversation

@martijn00
Copy link
Contributor

@martijn00 martijn00 commented Sep 3, 2024

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@martijn00
Copy link
Contributor Author

@Renzo-Olivares can you have a look at this?

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@martijn00
Copy link
Contributor Author

@Renzo-Olivares can you check too?

Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2024
@auto-submit auto-submit bot merged commit 3bbaf8c into flutter:main Sep 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 16, 2024
flutter/packages@330581f...df88c81

2024-09-14 [email protected] [webview_flutter] Improve flaky scroll tests (flutter/packages#7621)
2024-09-13 [email protected] Bump deps (flutter/packages#7357)
2024-09-13 [email protected] [flutter_adaptive_scaffold] Use improved MediaQuery methods (flutter/packages#7565)
2024-09-13 [email protected] [many] Update example android apps to target SDK level 34. (flutter/packages#7587)
2024-09-13 [email protected] [pigeon] adds support for non nullable types in collections (flutter/packages#7547)
2024-09-13 [email protected] [flutter_adaptive_scaffold] Adds additional slot animation parameters (flutter/packages#7411)
2024-09-13 [email protected] Roll Flutter from 303f222 to 2d30fe4 (21 revisions) (flutter/packages#7646)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: flutter_adaptive_scaffold

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants