Skip to content

Conversation

@bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Aug 7, 2024

Fixes the tests named ad_manager_tests.dart -> ad_manager_test.dart.

Also regenerates the mocks.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title fix test names [interactive_media_ads] Fix names of unit tests Aug 7, 2024
import 'package:interactive_media_ads/src/platform_interface/platform_interface.dart';
import 'package:mockito/annotations.dart';

@GenerateNiceMocks(<MockSpec<Object>>[MockSpec<ima.IMAAdsManager>()])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@auto-submit auto-submit bot merged commit 0363e42 into flutter:main Aug 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2024
@bparrishMines bparrishMines deleted the ima_test_names branch August 8, 2024 16:06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 8, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 8, 2024
flutter/packages@5cc0a01...bb797b9

2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207)
2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327)
2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336)
2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215)
2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
flutter/packages@5cc0a01...bb797b9

2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207)
2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327)
2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336)
2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215)
2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
flutter/packages@5cc0a01...bb797b9

2024-08-08 [email protected] [google_maps_flutter] Converts map configuration and platform view creation params to Pigeon (flutter/packages#7207)
2024-08-08 [email protected] [flutter_markdown] Fix table column alignment (flutter/packages#7327)
2024-08-08 [email protected] [interactive_media_ads] Fix names of unit tests (flutter/packages#7336)
2024-08-07 [email protected] [url_launcher] Convert Linux to Pigeon (flutter/packages#7215)
2024-08-07 [email protected] Roll Flutter from 0a7f8af to d595e98 (4 revisions) (flutter/packages#7334)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-android platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants